Item selector Management Toolbar shows orderByType options although no orderByColumns is set

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: Master
• Fix Version/s: 7.4.13 DXP U38, 7.4.3.38 CE GA38, 7.4.3.39 CE GA39, Master
• Component/s: Item Selector
• Labels:
  • 7.4-known-issues
  • 7.4.13-u38
  • liferay-ga25-ce-743-known-issues
  • liferay-ga26-ce-743-known-issues
  • liferay-ga27-ce-743-known-issues
  • liferay-ga28-ce-743-known-issues
  • liferay-ga29-ce-743-known-issues
  • liferay-ga30-ce-743-known-issues
  • liferay-ga31-ce-743-known-issues
  • liferay-ga32-ce-743-known-issues
  • liferay-ga33-ce-743-known-issues
  • liferay-ga34-ce-743-known-issues
  • liferay-ga35-ce-743-known-issues
  • liferay-ga36-ce-743-known-issues
  • liferay-ga37-ce-743-known-issues
• Story Points: 1
• Fix Priority: 3
• Sprint: Lima | QA Sprint 24
• Git Pull Request: https://github.com/liferay-lima/liferay-portal/pull/3319

 

This issue is reproducible using any ItemSelector rendered using the ItemSelectorViewDescriptorRenderer and without overriding getOrderByKeys ItemSelectorViewDescriptor method, for example, ObjectEntryItemSelectorView. We are using AssetVocabularyItemSelectorView because this bug was discovered testing this functionality. See: https://github.com/liferay/liferay-portal/blob/a47e8c6f8451add9806492239465f8788230cb49/modules/apps/asset/asset-vocabulary-item-selector-web/src/main/java/com/liferay/asset/vocabulary/item/selector/web/internal/AssetVocabularyItemSelectorView.java#L72-L78

 The difference we found between ObjectEntryItemSelectorView and AssetVocabularyItemSelectorView is that in the first one the icon is disabled and in the second one no, maybe is because ObjectEntryItemSelectorView has search disabled.

Step to reproduce:

1. Enable feature via groovy script

   import com.liferay.portal.util.PropsUtil;
   import java.util.Properties;
   
   Properties properties = new Properties();
   properties.setProperty("feature.flag.LPS-146502","true");
   PropsUtil.addProperties(properties);
   

1. Navigate to Navigation Menus admin on the default site
2. Add a navigation menu
3. Add a Vocabulary item

Expected Results:
The toolbar doesn't display the order by type icon because ordering is not an option

Actual Results:
The toolbar displays the order by type icon although the ordering is not an option