Default "User" role can be removed from default association

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 7.3.X, Master
• Fix Version/s: 7.2.X, 7.3.X, 7.4.3.26 CE GA26, 7.4.3.27 CE GA27, Master
• Component/s: User Management > Roles
• Labels:
  • backend_test
  • ee-ts
  • liferay-fixpack-dxp-20-7210
  • liferay-fixpack-dxp-6-7310
  • liferay-update-dxp-27-7413
  • liferay-update-dxp-6-7310
• Branch Version/s:
  7.3.x, 7.2.x
• Backported to Branch:
  Committed
• Fix Priority: 3
• Git Pull Request: https://github.com/brianchandotcom/liferay-portal/pull/117722

With the inclusion of LPS-134096, a small condition was added to return early if all default roles were already associated with the user.  This can cause problems however, because it was determined in this comment the "User" role should always be assigned to the user, even when explicitly removed from the Default User Associations entry has been removed.

This ticket describes the opposite behavior of LPS-149351, which was closed as "Won't Fix".

Steps to reproduce:

1. Go to Instance Settings > Users > Default User Associations.
2. Remove the "user" role.  Save.
3. Create a new user.
4. Look at the newly created user's "user_roles" entrie(s) in the DB (the "User" role will not appear in the Roles Admin portlet, so using the DB is the only way to verify it's been assigned or not).

Expected Results:

New user should still have the "User" role.

Actual Results:

New user does not have the "User" role.