Staging activation errors for sites with a name of a specific length

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 7.4.3.58 CE GA58
• Fix Version/s: 7.3.10 DXP U22, 7.3.X, 7.4.13 DXP U66, 7.4.3.66 CE GA66, Master
• Component/s: Content Publishing > Staging, Sites Administration > Sites
• Labels:
  • 7.3.10-u22
  • 7.4.13-u66
  • Liferay-fixpack-dxp-22-7310
  • Liferay-update-update-dxp-22-7310
  • NAT
  • ee-ts
  • staging-qa
• Branch Version/s:
  7.3.x
• Backported to Branch:
  Committed
• Story Points: 3
• Fix Priority: 3
• Git Pull Request: https://github.com/liferay-staging/liferay-portal/pull/229 https://github.com/liferay-staging/liferay-portal/pull/235 https://github.com/liferay-staging/liferay-portal/pull/239 https://github.com/brianchandotcom/liferay-portal/pull/130252
• Bug Type: Default

Reproduction steps:

1/ Create a new site with this name:

The very important site that deals with very complex stuff no one has a clue about but we don't want to think about no more in the upcoming weeks
 
2/ Try to enable local staging => Failure with a vague message "Error:Your request failed to complete."
 
3/ Rename the site to:
 
The very important site that deals with very complex stuff no one has a clue about but we don't want to think about no more
 
4/ Try to enable local staging => Success
 
Analysis:
 
The length of that name is 146 characters which is below the limit of the group key size (150 characters).
However, during staging activation, a new Group entry will be created and its group key will be the original live group key + something like "staging" behind.
 
So this error will only happen with some very specific site names.
 
The exception is thrown here: https://github.com/liferay/liferay-portal/blob/7.3.x/portal-impl/src/com/liferay/portal/service/impl/GroupLocalServiceImpl.java#L4907
 
There are two issues here:
1/ We don't provide an error message which makes it possible for the site administrator to understand what's wrong.
2/ We need a safeguard: maybe adjusting the size of the groupKey column in order to have some spare characters to append "staging" and add a rule to prevent administrators from creating sites with a name that would eat up those spare characters.