Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-1790

<layout-template>'s with duplicated Id's are allowed in liferay-layout-templates.xml

    Details

    • Type: Bug
    • Status: Closed
    • Resolution: Won't Fix
    • Affects Version/s: 5.1.2, 5.2.0
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Liferay Contributor's Agreement:
      Accept

      Description

      If an admin creates two or more templates with the same id, but different sets of columns, all sorts of weirdness ensues in the portal.

      Such as being able to place portlets but not move or remove them.

      XML configs with multiple instances of the same ID should not be allowed.

        Activity

        Hide
        jesperw Jesper We (Inactive) added a comment -

        Ignore subsequent duplicates, keep processing rest of templates.

        Show
        jesperw Jesper We (Inactive) added a comment - Ignore subsequent duplicates, keep processing rest of templates.
        Hide
        brian.chan Brian Chan added a comment - - Restricted to

        Rolled it back because this fix causes other bugs.

        It no longer allows overriding of definitions via subsequent xmls, see block:

        for (int i = 0; i < xmls.length; i++) {
        Set<ObjectValuePair<String, Boolean>> curLayoutTemplateIds =
        _readLayoutTemplates(
        servletContextName, servletContext, xmls[i],
        pluginPackage);

        Show
        brian.chan Brian Chan added a comment - - Restricted to Rolled it back because this fix causes other bugs. It no longer allows overriding of definitions via subsequent xmls, see block: for (int i = 0; i < xmls.length; i++) { Set<ObjectValuePair<String, Boolean>> curLayoutTemplateIds = _readLayoutTemplates( servletContextName, servletContext, xmls [i] , pluginPackage);

          People

          • Assignee:
            support-lep@liferay.com SE Support
            Reporter:
            jesperw Jesper We (Inactive)
            Recent user:
            Randy Zhu (Inactive)
            Participants of an Issue:
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Days since last comment:
              7 years, 36 weeks, 1 day ago

              Development

                Subcomponents