Details

    • Liferay Contributor's Agreement:
      Accept
    • Similar Issues:
      Show 4 results 

      Description

      Set auto.deploy.unpack.war=false in portal-ext.properties.

      When deploying plugin containing my own version of manifest.mf in META-INF directory this manifest is replaced by generic one containing just Manifest-Version, Ant-Version and Created-By.

      My manifest contains build info, class-path, vendor information and so on. This information disappears during deployment.

      There should be configuration option whether I want to keep original manifest.

      Short investigation shows it's probably due ANT task called during deployment - WarTask.war(). Change seems to be trivial as used Ant task supports this behavior.

      http://www.docjar.com/docs/api/org/apache/tools/ant/taskdefs/Jar.html#setFilesetmanifest%28FilesetManifestConfig%29

        Activity

        Hide
        Tammy Fong added a comment -

        Hi Jaromir,

        Thank you for you report. I am unable to reproduce the situation described. I made changes to my MANIFEST.MF (Manifest-version, Archiver-Version, Created-By, etc) then successfully deploy the war. After converting the war file, the same MANIFEST.mf file is found; the information wasn't reverted. If you still experience this issue, please provide additional information and we can re-visit it. Thanks,

        Show
        Tammy Fong added a comment - Hi Jaromir, Thank you for you report. I am unable to reproduce the situation described. I made changes to my MANIFEST.MF (Manifest-version, Archiver-Version, Created-By, etc) then successfully deploy the war. After converting the war file, the same MANIFEST.mf file is found; the information wasn't reverted. If you still experience this issue, please provide additional information and we can re-visit it. Thanks,
        Hide
        Jaromir Hamala added a comment -

        Hello Tammy,

        thank you for looking at this issue. This bug occurrs only when deploying packed WAR containing the plugin. Liferay running on Tomcat uses exploded deployers by default. That's most likely the reason why you couldn't reproduce the issue.

        When running Liferay on some other servers than Tomcat one cannot use exploded deployers. For example on WebSphere first you need to let Liferay to process the WAR. Output of this tranformation is another WAR (the one you deploy to WebSphere itself) And in this WAR is the manifest.mf replaced.

        You can achieve some behaviour on Tomcat with following settings in portal-ext.properties:

        auto.deploy.unpack.war=false
        Show
        Jaromir Hamala added a comment - Hello Tammy, thank you for looking at this issue. This bug occurrs only when deploying packed WAR containing the plugin. Liferay running on Tomcat uses exploded deployers by default. That's most likely the reason why you couldn't reproduce the issue. When running Liferay on some other servers than Tomcat one cannot use exploded deployers. For example on WebSphere first you need to let Liferay to process the WAR. Output of this tranformation is another WAR (the one you deploy to WebSphere itself) And in this WAR is the manifest.mf replaced. You can achieve some behaviour on Tomcat with following settings in portal-ext.properties: auto.deploy.unpack.war= false
        Hide
        Tammy Fong added a comment -

        Hi Jaromir,
        Thank you for the additional information. When the above property is set, then the deployed MANIFEST.MF does become replaced with the following:

        Manifest-Version: 1.0
        Ant-Version: Apache Ant 1.8.2
        Created-By: 1.6.0_21-b07 (Sun Microsystems Inc.)

        I will update the ticket to reflect the issue.

        Show
        Tammy Fong added a comment - Hi Jaromir, Thank you for the additional information. When the above property is set, then the deployed MANIFEST.MF does become replaced with the following: Manifest-Version: 1.0 Ant-Version: Apache Ant 1.8.2 Created-By: 1.6.0_21-b07 (Sun Microsystems Inc.) I will update the ticket to reflect the issue.
        Hide
        Jaromir Hamala added a comment -

        well, the manifest is replaced either when property is set OR when plugin is deployed to other application server than Tomcat, e.g. WebSphere.

        Show
        Jaromir Hamala added a comment - well, the manifest is replaced either when property is set OR when plugin is deployed to other application server than Tomcat, e.g. WebSphere.
        Hide
        Vicki Tsang added a comment -

        Reopening issue as this appears to have been moved into Contributed Solution in error. If this is not correct, please attach a patch file, reselect the Contribute Solution button and accept the Liferay Contributor's Agreement. Submissions cannot be considered for inclusion, unless the agreement is accepted.

        Thanks,
        The Liferay Team

        Show
        Vicki Tsang added a comment - Reopening issue as this appears to have been moved into Contributed Solution in error. If this is not correct, please attach a patch file, reselect the Contribute Solution button and accept the Liferay Contributor's Agreement. Submissions cannot be considered for inclusion, unless the agreement is accepted. Thanks, The Liferay Team
        Hide
        Michael Saechang added a comment -

        Committed on:
        Portal 6.2.x GIT ID: aa42f6aa94abc6c5d94c30535109f96078e476d0.

        Show
        Michael Saechang added a comment - Committed on: Portal 6.2.x GIT ID: aa42f6aa94abc6c5d94c30535109f96078e476d0.
        Hide
        Sharry Shi added a comment -

        PASSED Manual Testing following the steps in the description.

        Reproduced on:
        Tomcat 7.0 + MySQL 5. Portal 6.1.0 CE RC1.
        Tomcat 7.0 + MySQL 5. Plugin 6.1.x EE GIT ID: f25c2d3efbb385066bcfe77a38808d5563449282.

        Liferay will change your modification in manifest.mf when deploying plugin.

        Fixed on:
        Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 8366bb10b25827ebce6c213ba98cbd63f512fffa.
        Tomcat 7.0 + MySQL 5. Plugin 6.2.x GIT ID: 9b82c4562cb97d7b2b2520dc130ad42bb47a3eef.

        Liferay will not change your modification in manifest.mf when deploying plugin.

        Show
        Sharry Shi added a comment - PASSED Manual Testing following the steps in the description. Reproduced on: Tomcat 7.0 + MySQL 5. Portal 6.1.0 CE RC1. Tomcat 7.0 + MySQL 5. Plugin 6.1.x EE GIT ID: f25c2d3efbb385066bcfe77a38808d5563449282. Liferay will change your modification in manifest.mf when deploying plugin. Fixed on: Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 8366bb10b25827ebce6c213ba98cbd63f512fffa. Tomcat 7.0 + MySQL 5. Plugin 6.2.x GIT ID: 9b82c4562cb97d7b2b2520dc130ad42bb47a3eef. Liferay will not change your modification in manifest.mf when deploying plugin.
        Hide
        Michael Saechang added a comment -

        Thank you Sharry for testing. Closing as 'Fixed'.

        Show
        Michael Saechang added a comment - Thank you Sharry for testing. Closing as 'Fixed'.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Days since last comment:
              2 years, 49 weeks, 2 days ago

              Development

                Structure Helper Panel