Details

    • Type: Bug
    • Status: Closed
    • Resolution: Fixed
    • Affects Version/s: 5.2.1, 5.2.2
    • Fix Version/s: 5.2.3
    • Component/s: None
    • Labels:
      None
    • Environment:
      Linux / Ubuntu 8.10
    • Branch Version/s:
      5.1.x
    • Backported to Branch:
      Committed
    • Liferay Contributor's Agreement:
      Accept

      Description

      The MinifierFilter introduced in 5.2.x doesn't work properly with embedded Javascript with comments.

      Example:

      <SCRIPT>
      // some comment
      some script
      </SCRIPT>

      The result is then is minified like this:
      <SCRIPT>
      // some comment some script
      </SCRIPT>

      The javascript code is now considered as comment by the browser.
      Liferay is producing new javascript errors.

      SOLUTION: remove commented lines before processing.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                douglas.wong Douglas Wong
                Reporter:
                swerlen Sven Werlen
                Participants of an Issue:
                Recent user:
                Esther Sanz
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Days since last comment:
                  10 years, 31 weeks, 5 days ago

                  Packages

                  Version Package
                  5.2.3