NPE exception on LDAP import

• Type: Technical Task
• Status: Closed
• Resolution: No Longer Reproducible
• Affects Version/s: --Sprint 12/11
• Fix Version/s: --Sprint 12/11, 6.1.0 CE RC1
• Component/s: Application Security > LDAP, Portal Services
• Labels:
  • QA-R
  • bugsquad
  • trunk

Hello,

with trunk (in fact since revision changes 92262 committed on Nov. 2nd) there is a problem with the LDAP import if there are fields that are not mapped. Prior to this, you could e.g. leave the Middle Name field unmapped and the LDAP import would work. Since this revision, you get a NPE on the LDAP import.

The problem is related to the code redesign in the following method:
public static String getAttributeString(
Attributes attributes, String id, String defaultValue)
throws NamingException {

Attribute attribute = attributes.get(id);

if (attribute == null)

{ return defaultValue; }

Object object = attribute.get();

if (object == null) { return defaultValue; }

return object.toString();
}

the method call Attribute attribute = attributes.get(id); can throw a NPE and that exception is not catched in the code.

Prior to this change the code looked like this:
public static Object getAttributeValueAsObject(
Attributes attributes, String id, Object defaultValue)
throws NamingException {

try

{ Attribute attribute = attributes.get(id); Object obj = attribute.get(); return obj; }

catch (NullPointerException npe)

{ return defaultValue; }

}

here the method call Attribute attribute = attributes.get(id); took place within the try catch statement and the NPE was explicitly catched.

So simply changing the code like this should solve the problem:

Attribut attribute = null;
try

{ attribute = attributes.get(id); }

catch (NullPointerException npe)

{ return defaultValue; }

[Alex Weirig]

In fact the problem is also present in another method.

I fixed the code and tested it, now it works again. Here's my patch:

1. 1. 1. Eclipse Workspace Patch 1.0
         #P portal-trunk
         Index: util-java/src/com/liferay/util/ldap/LDAPUtil.java
         ===================================================================
      • util-java/src/com/liferay/util/ldap/LDAPUtil.java (revision 93339)
        +++ util-java/src/com/liferay/util/ldap/LDAPUtil.java (working copy)
        @@ -63,7 +63,13 @@
        Attributes attributes, String id, Object defaultValue)
        throws NamingException {

• Attribute attribute = attributes.get(id);
  + Attribute attribute = null;
  +
  + try { + attribute = attributes.get(id); + }

  catch (NullPointerException npe)

  { + return defaultValue; + }
  
  if (attribute == null) {
  return defaultValue;
  @@ -107,7 +113,12 @@
  Attributes attributes, String id, String defaultValue)
  throws NamingException {
  
  - Attribute attribute = attributes.get(id);
  + Attribute attribute = null;
  + try { + attribute = attributes.get(id); + } catch (NullPointerException npe) {+ return defaultValue;+ }

if (attribute == null) {
return defaultValue;

[Traolly Xiong (Inactive)]

Thank you. I'll give it try.

Regards,
Traolly Xiong

[Traolly Xiong (Inactive)]

Trying to download trunk via SVN GUI and running this command I get an error:

Step:

Run Build Scripts #

Verify the path to your tomcat directory is correct or the build will fail (see Configure Trunk). You need to run three separate commands in this order

cd

{full path}

/liferay-code/trunk
ant -buildfile build-dist.xml unzip-tomcat // Running this command I get an error below
ant all

Error:

C:\Liferay_TRUNK\liferay-code\trunk>ant -buildfile build-dist.xml unzip-tomcat
Buildfile: build-dist.xml does not exist!
Build failed

Am I missing something here?

[Michael Saechang]

You are running the command in the wrong directory. The directory you are running that command in should be where the source files are. There should be a build.xml and build-dist.xml.

[Traolly Xiong (Inactive)]

I'm still not too familiar on how we should use the trunk. Should we check out the trunk to our actual bundle NT file install and when
there's a change to the trunk we can do a svn update to get the latest fix for assets? Or is it just to download/view/compare with the current bundle source files that are currently installed?

Let me know.

Regards,
Traolly Xiong

[Alex Weirig]

Hello Traolly,

when it comes to trunk, here's what I do:
1) I check out the code from svn into a dedicated directory
2) I configure my build.properties and then I build the code
3) I deploy to a dedicated Tomcat server (not sure what you mean with bundle NT file install)
4) when I'm working on trunk, I run an svn update every morning to get the latest code, then I build again and deploy to my test Tomcat environment
5) if appropriate and needed, I deploy my theme, portlets, hooks etc to this test server
6) also, make sure you have a dedicated test database for trunk, the database structure on trunk is likely to change on a regular base so you'd have to drop and recreate the database

So basically, when you check out from trunk you get the entire source code with all assets. So you can do whatever you need on that source code (fix bugs, test things ...) and yes, as I said, you can always run an svn update to get the latest. In that case you just have to take care of changes you might have done to the source code (merge them, copy them back from a diff file ...)

You might also want / have to checkout the plugins SDK from trunk, depending on what you want / need to do.

That's just what I do ... it works for me hopefully it can help you.

Regards,

Alex