Misleading error message when adding a Portal Instance

• Type: Regression Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 6.1.0 CE RC1, 6.2.0 CE M2
• Fix Version/s: 6.1.10 EE GA1, 6.1.20 EE GA2, --Sprint 11/12, 6.2.0 CE M2
• Component/s: Portal Configuration, Portal Configuration > Portal Instances
• Labels:
  • QA-R
  • bugsquad
• Environment: Tomcat 7.0.22 + MySQL 5. 6.1.x Revision: 93700.
• Branch Version/s:
  6.1.x
• Backported to Branch:
  Committed
• Story Points: 1
• Fix Priority: 2
• Added to Fix Pack:
  Added
• Git Pull Request: https://github.com/brianchandotcom/liferay-portal/pull/4320

Navigate to Control Panel - Server / Portal Instances
Click Add

Enter:
Web ID: tiat
Virtual Host: tiat.tigercubtech.com
Mail Domain: tigercubtech.com
Max Users: 0
Active: checked

Click Save

The error message returned is "Please enter a valid virtual host."

In debugging to see why it said the host was invalid, I found that CompanyLocalServiceImpl.checkCompany initializes virtualHost to the webId. If the Web ID is not a valid domain name, the above error is returned even if the virtual host is valid.

The documentation for Web ID in http://www.liferay.com/documentation/liferay-portal/6.0/administration/-/ai/global-server-settin-4 says "A general convention is to use the domain name for this. It's a user-generated ID for the instance." Prior versions of Liferay did not require that the Web ID was a valid domain name.

If Web ID must be a valid domain the error message should be updated to point the admin in the right direction. If that isn't the intent then the validation seems to be wrong.