Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-24224

RoleLocalServiceImpl checkSystemRole faulty optimization

    Details

      Description

      Method RoleLocalServiceImpl.checkSystemRole(long companyId, String name, Map<Locale, String> descriptionMap, int type) contains optimization which is not working, but the method roleLocalService.updateRole(role, false) is always executed.

      if (!role.getDescription().equals(descriptionMap)) {
      	role.setDescriptionMap(descriptionMap);
      
      	roleLocalService.updateRole(role, false);
      }
      

      Solution remove if statement or implement equals correctly {{if (!role.getDescriptionMap().equals(descriptionMap)) }}

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Days since last comment:
                7 years, 36 weeks, 4 days ago

                Packages

                Version Package
                --Sprint 12/11
                6.1.0 CE RC1
                6.2.0 CE M2