Details

    • Branch Version/s:
      6.1.x, 6.0.x
    • Backported to Branch:
      Committed
    • Fix Priority:
      3
    • Similar Issues:
      Show 4 results 

      Description

      The CSS-Minifier does not properly minify media queries that contain AND-conditions.

      The following statement
      — cut —
      @media (max-width: 750px) and (min-width: 520px) {
      .mydiv

      { background-color:red; }

      }
      — cut —

      gets parsed as follows:
      — cut —
      @media(max-width:750px) and(min-width:520px){.mydiv{background-color:red;}}
      — cut —

      which renders the entire media query useless (see the removed blank between "and" and the opening bracket).
      When I use firebug to manually (re-)inject the space character the query is working fine.

      Deactivating the minifier ("minifier.inline.content.cache.size=0" in portal-ext.properties) works around the issue. However, this is not suitable for a production environment.

        Issue Links

          Activity

          Hide
          Nate Cavanaugh added a comment -

          This one can be backported across the board.

          Thanks guys,

          Show
          Nate Cavanaugh added a comment - This one can be backported across the board. Thanks guys,
          Hide
          Lawrence Lee added a comment -

          Committed on:
          Portal 6.1.x EE GIT ID: 168e70c280004be2902f9f01f161bc01c16d41ca.
          Portal 6.2.x GIT ID: dc9b5fe49a7dc2c9f02af415c529b338856be464.

          Show
          Lawrence Lee added a comment - Committed on: Portal 6.1.x EE GIT ID: 168e70c280004be2902f9f01f161bc01c16d41ca. Portal 6.2.x GIT ID: dc9b5fe49a7dc2c9f02af415c529b338856be464.
          Hide
          Albert Lee added a comment -

          PASSED Manual Testing following the steps in the comment by Drew using a slightly modified statement.

          @media (max-width: 750px) and (min-width: 520px) {
          body

          { background-color:red; }

          }

          Reproduced on:
          Tomcat 7.0 + MySQL 5. Portal 6.1.x GIT ID: 6dbfe00ad713e11040a2e12891ae859fad0de081.

          After adding the css media query, when I resized the browser to a width between 520 and 750 pixels, the body background color did not change.

          Fixed on:
          Tomcat 7 + MySQL 5. Portal 6.1.x GIT ID: 844a9390cfc57ce5d12770d26ac9f09f42a9afd4.
          Tomcat 7 + MySQL 5. Portal 6.2.x GIT ID: e1fdb0fa6c7cbad2f8f322d24fe872766257aff0.

          After adding the css media query, when I resized the browser to a width between 520 and 750 pixels, the body background color changed to red.

          Show
          Albert Lee added a comment - PASSED Manual Testing following the steps in the comment by Drew using a slightly modified statement. @media (max-width: 750px) and (min-width: 520px) { body { background-color:red; } } Reproduced on: Tomcat 7.0 + MySQL 5. Portal 6.1.x GIT ID: 6dbfe00ad713e11040a2e12891ae859fad0de081. After adding the css media query, when I resized the browser to a width between 520 and 750 pixels, the body background color did not change. Fixed on: Tomcat 7 + MySQL 5. Portal 6.1.x GIT ID: 844a9390cfc57ce5d12770d26ac9f09f42a9afd4. Tomcat 7 + MySQL 5. Portal 6.2.x GIT ID: e1fdb0fa6c7cbad2f8f322d24fe872766257aff0. After adding the css media query, when I resized the browser to a width between 520 and 750 pixels, the body background color changed to red.
          Hide
          Albert Lee added a comment -

          PASSED Manual Testing following the steps outlined in my previous comment on 07/25/2012.

          Tomcat 6 + MySQL 5. Portal 6.0.x GIT ID: 99341ed5f91ba1b9eb3ee2c50752b4b864f06841.

          Show
          Albert Lee added a comment - PASSED Manual Testing following the steps outlined in my previous comment on 07/25/2012. Tomcat 6 + MySQL 5. Portal 6.0.x GIT ID: 99341ed5f91ba1b9eb3ee2c50752b4b864f06841.
          Hide
          Edward Gonzales added a comment -

          Hello everyone! We are in the process of moving component "Theme" to "Theme > Dev" in LPS. Please make the necessary adjustments to your filters. Thanks!

          Show
          Edward Gonzales added a comment - Hello everyone! We are in the process of moving component "Theme" to "Theme > Dev" in LPS. Please make the necessary adjustments to your filters. Thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Days since last comment:
                2 years, 5 weeks, 3 days ago

                Development

                  Structure Helper Panel