Display on Page is not working for non-english locale Russian

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 6.1.0 CE GA1, 6.1.1 CE GA2, 6.1.10 EE GA1, 6.1.20 EE GA2
• Fix Version/s: 6.1.10 EE GA1, 6.1.2 CE GA3, 6.1.30 EE GA3, 6.2.0 CE M2
• Component/s: WCM, WCM > Publication > Asset Publisher
• Labels:
  • QA-R
• Branch Version/s:
  6.1.x
• Backported to Branch:
  Committed
• Fix Priority: 3
• Similar Issues: Show 5 results ; ;

  LPS-30708	Display page does not work for non-english locales Chinese, Korean and Japanese
  LPS-14786	RSS does not properly display non-English character
  LPS-3553	Links in BlogAggregator broken for articles with non-english (russian) title
  LPS-30138	Weather portlet no longer accepts non-English names
  LPS-12648	Page Localization Name displayed in alternate language

1. Setup Liferay portal with two pages:
1.1 one with "source" asset publisher and "Language" portlet
1.2 another page with asset publisher defined as "default for this page"
2. Congigure first asset publisher: Asset Link Behavior: "View in Specific Portlet"
3. Switch to non-english locale (in my case I've switched into Russian)
4. Add new webcontent to display in asset publisher. Then created - set Display Page property of created web-content to display on second page.

After creation web-content is displayed on first publisher. On click on this content it is expected what it will be displayed in second page. But browser displayed first page of group
In case we edit content with english (en_US) language - it is working as expected (web-content is opened in target page).
I'm expecting problem in searching for asset by title user in friendly url

This problem is not reproduced in Liferay 6.1.10 EE

[Alexey Kakunin]

Just tested additionaly - this problem also reproduced in 6.1.10 EE.
To reproduce problem - no needs to create web-content in specific language.
Issue in using language prefix in URL and using non-ascii symbols in web-content title.
If I'm navigating to:
http://localhost:8080/web/smartphones/-/%D1%8D%D1%82%D0%BE-%D0%BD%D0%BE%D0%B2%D0%BE%D1%81%D1%82%D1%8C-%D0%BD%D0%B0-%D1%80%D1%83%D1%81%D1%81%D0%BA%D0%BE%D0%BC
jourtal article found well and it is displayed on related page
If I'm trying to navigate to
http://localhost:8080/ru/web/smartphones/-/%D1%8D%D1%82%D0%BE-%D0%BD%D0%BE%D0%B2%D0%BE%D1%81%D1%82%D1%8C-%D0%BD%D0%B0-%D1%80%D1%83%D1%81%D1%81%D0%BA%D0%BE%D0%BC
journal article is not found and default site page is displayed.

It happens because in first (correct) case method PortalImpl.getJournalArticleActualURL received decoded friendlyURL, but in second case - not decoded - and as result cannot find specific journal article

[Alexey Kakunin]

In my cases for fixing this issue I've added followed class as service hook. But I'm not sure it is correct place to do decode - probably it should be done in I18NServlet

public class PortalImplExt extends PortalImpl {
public String getJournalArticleActualURL(
long groupId, String mainPath, String friendlyURL,
Map<String, String[]> params, Map<String, Object> requestContext)
throws PortalException, SystemException

{ // this is fix for http://issues.liferay.com/browse/LPS-25913 // try to do urldecode for specified friendly URL _log.debug("url before decode: " + friendlyURL); friendlyURL = URLDecoder.decode(friendlyURL); _log.debug("decoded url: " + friendlyURL); return super.getJournalArticleActualURL(groupId, mainPath, friendlyURL, params, requestContext); }

private static Log _log = LogFactoryUtil.getLog(PortalImplExt.class);
}

[Tamas Molnar]

Thanks Alexey for your contribution, I am creating a solution for Liferay 6.1.10 EE and 6.2.X based on your work.

[Mate Thurzo]

Tamás, can you please perform the changes Sergio has advised and we discussed? Thanks!

[Alexey Kakunin]

Another problem related to this issue:
Lets create web-content with long (but acceptable) russian title: for example 150 symbols (acceptable length is 255).
If we will try to access this web-content by URL: http://hostname/-/quite-long-title-of-article-in-russian - it will be failed to find.
But if we will access it by http://hostname/web/guest/-/quite-long-title-of-article-in-russian - it will work.

Problem is in VirtualHostFilter class - in it's method isValidFriendlyURL
It called
int code = LayoutImpl.validateFriendlyURL(friendlyURL);

this mehtod also checks for length of url - and here is a problem.
Since russian symbols comes encoded (as %D0%BC%D0%BE%D1%81%D0%B3 ... ) - checked string is much longer then original title - so, it is not passed this check - and whole logic for processing this url goes incorrectly.

Here I see 2 solutions:
1. Friendly URL should be decoded somethere before (but I'm not sure there exactly - since it comes deep into Liferay internals)
2. We should ignore error LayoutFriendlyURLException.TOO_LONG in method VirtualHostFilter.isValidFriendlyURL

[Tamas Molnar]

The main problem is the following:
In the Normalizer.java the normalizeToAscii method doesn't care about the Cyrillic characters. If we use Cyrillic-Latin transliterator there will be only two problematic characters : ' (UNICODE: 02B9) and " (UNICODE: 02BA). After that, we can use the StringUtil.replace method to change these characters(as it works correctly for the polish Ł character). This solution seems to work correctly, and solves both of the problems mention above.

Tables showing UNICODE characters in UTF-8 conversion: http://titus.uni-frankfurt.de/unicode/unitestx.htm

[Brian Chan]

Fix is in https://github.com/brianchandotcom/liferay-portal/pull/4838 but won't pull in unless there is a unit test.

[Boris Yurkevich]

My posts with Long Cyrillic titles not opening. URL redirects to a previous page.
I implemented this fix in ext plugin. It not helped me.
Is this commit supposed to fix my bug?
Here is more information about my ext plugin http://stackoverflow.com/questions/10894849/liferay-ext-plugin-rewriting-java-class-in-util-java

[Mate Thurzo]

I'm going to develop the test for this, because it's been stuck there for a while. I'm going to send the PR to you Brian after I'm done with it, so you can merge it together.

Thanks,

Máté

[Mate Thurzo]

Brian, here goes the change again with the unit test added.

[Michael Saechang]

Committed on:
Portal 6.2.x GIT ID: 76bb75b643c53869801c61e69b882a38b0a83512.

[Pani Gui]

PASSED Manual Testing following the steps in the description.

Reproduced on:
Tomcat 7.0 + MySQL 5. Portal 6.1.20 EE GA2.

Display page does not work for non-english locale on Asset Publisher.

Fixed on:
Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: 30ba0e21ec4cf4cfa456d152efec173ae6828801.
Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 26db36dd1d8cb06b88163a37d3fd7dfecb175e4b.

Display page works for Russian locale on Asset Publisher.

[Michael Saechang]

Thank you Pani for testing. Closing as 'Fixed'.