Details

    • Branch Version/s:
      6.1.x
    • Backported to Branch:
      Committed
    • Business Value:
      4
    • Similar Issues:
      Show 5 results 

      Description

      Announcements are not sent if display date is in the past and announcement check interval passes while creating the announcement.

      This can be achieved by setting announcements.entry.check.interval=1 and creating announcement and waiting 1 minute before hitting save. This happens because display date is set to "current time" when entry is started being edited and if announcements entry check happens before user saves the entry it will not get sent (if user does not alter the display date manually).

        Issue Links

          Activity

          Hide
          David Kubitza added a comment -

          Whenever display date < now - interval there are no notification emails sent out. I found this code which seems to be the reason:
          https://github.com/liferay/liferay-portal/blob/master/portal-impl/src/com/liferay/portlet/announcements/service/impl/AnnouncementsEntryLocalServiceImpl.java#L130

          As this is current master trunk it also affects Liferay 6.2.X.

          In line 134 (https://github.com/liferay/liferay-portal/blob/master/portal-impl/src/com/liferay/portlet/announcements/service/impl/AnnouncementsEntryLocalServiceImpl.java#L134) it fetches announcements by display date which is clearly wrong because the user can manipulate the display date in any kind. Here you need to use the creation date of the announcement, as it can't be changed by the user. The modification date would also be an option, if notifications should also be send after a change of an existing announcement.

          Show
          David Kubitza added a comment - Whenever display date < now - interval there are no notification emails sent out. I found this code which seems to be the reason: https://github.com/liferay/liferay-portal/blob/master/portal-impl/src/com/liferay/portlet/announcements/service/impl/AnnouncementsEntryLocalServiceImpl.java#L130 As this is current master trunk it also affects Liferay 6.2.X. In line 134 ( https://github.com/liferay/liferay-portal/blob/master/portal-impl/src/com/liferay/portlet/announcements/service/impl/AnnouncementsEntryLocalServiceImpl.java#L134 ) it fetches announcements by display date which is clearly wrong because the user can manipulate the display date in any kind. Here you need to use the creation date of the announcement, as it can't be changed by the user. The modification date would also be an option, if notifications should also be send after a change of an existing announcement.
          Hide
          Serena Song (Inactive) added a comment -

          Blocked by LPS-35628

          Show
          Serena Song (Inactive) added a comment - Blocked by LPS-35628
          Hide
          Serena Song (Inactive) added a comment - - edited

          PASSED Manual Testing using the following steps:

          1. Open portal-ext.properties, add announcements.entry.check.interval=1 and following to the file :
                announcements.email.from.name=liferay.qa1
                announcements.email.from.address=liferay.qa1@gmail.com
            
                announcements.email.to.name=liferay.qa2
                announcements.email.to.address=liferay.qa2@gmail.com
            
                announcements.email.subject=com/liferay/portlet/announcements/dependencies/email_subject.tmpl
                announcements.email.body=com/liferay/portlet/announcements/dependencies/email_body.tmpl
            
          2. Login an Admin user
          3. Click My Account and click Display Setting
          4. Make sure that Admin user is set to the correct Time zone under Display Setting category matching the time zone on your computer.
          5. Click Announcements under Miscellaneous.
          6. Select all the email option and save.
          7. Go to control panel and set up mail server in the Server Administration.
          8. Back to liferay.com and add Announcement portlet to a page
          9. Click on "Manage Entries" tab.
          10. Click on "Add Entry" button.
          11. Verify that Display Date displays current time (the same as your computer).
          12. Populate Title field and Content section.
          13. Waiting 1 minute and then click on Save button.

          Reproduced on:
          Tomcat 7.0 + MySQL 5. Portal 6.1.x 6.1.20 EE GA2.

          Alarms/Announcements are not sent if display date is in the past.

          Fixed on:
          Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: 4b656be2d9b9bba35f13bec9304ba1eeb291a73d.
          Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 3decc66ba8f797d0e63c1fd82f74e2ff854fb753.

          You can receive a notification email.

          Show
          Serena Song (Inactive) added a comment - - edited PASSED Manual Testing using the following steps: Open portal-ext.properties, add announcements.entry.check.interval=1 and following to the file : announcements.email.from.name=liferay.qa1 announcements.email.from.address=liferay.qa1@gmail.com announcements.email.to.name=liferay.qa2 announcements.email.to.address=liferay.qa2@gmail.com announcements.email.subject=com/liferay/portlet/announcements/dependencies/email_subject.tmpl announcements.email.body=com/liferay/portlet/announcements/dependencies/email_body.tmpl Login an Admin user Click My Account and click Display Setting Make sure that Admin user is set to the correct Time zone under Display Setting category matching the time zone on your computer. Click Announcements under Miscellaneous. Select all the email option and save. Go to control panel and set up mail server in the Server Administration. Back to liferay.com and add Announcement portlet to a page Click on "Manage Entries" tab. Click on "Add Entry" button. Verify that Display Date displays current time (the same as your computer). Populate Title field and Content section. Waiting 1 minute and then click on Save button. Reproduced on: Tomcat 7.0 + MySQL 5. Portal 6.1.x 6.1.20 EE GA2. Alarms/Announcements are not sent if display date is in the past. Fixed on: Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: 4b656be2d9b9bba35f13bec9304ba1eeb291a73d. Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 3decc66ba8f797d0e63c1fd82f74e2ff854fb753. You can receive a notification email.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Days since last comment:
                2 years, 14 weeks, 3 days ago

                Development

                  Subcomponents

                    Structure Helper Panel