Tomcat bundle setenv.[sh|bat] should set CATALINA_OPTS instead of JAVA_OPTS

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 6.1.0 CE GA1, 6.1.10 EE GA1, 6.2.0 CE M2
• Fix Version/s: 6.1.X EE, --Sprint 11/12, 6.2.0 CE M2
• Component/s: Environments, Environments > App Servers
• Labels:
  • QA-R
• Environment: standard tomcat bundle
• Branch Version/s:
  6.1.x
• Backported to Branch:
  Committed
• Story Points: 1
• Git Pull Request: https://github.com/igorspasic/liferay-portal/pull/5

The standard memory settings are in JAVA_OPTS, done in setenv.sh and setenv.bat. This is bad practice and should be changed to CATALINA_OPTS. One example for why it's bad: JAVA_OPTS is used to start any java process, including the shutdown of Tomcat. If you allocate 8G of RAM for running tomcat, you don't want to allocate these for the JVM that gets started up just to tell tomcat to stop (there will be a second process for short time). If all the memory is allocated immediately, shutting down might even fail with OutOfMemory Exceptions