Details

    • Branch Version/s:
      6.1.x
    • Backported to Branch:
      Committed
    • Similar Issues:
      Show 3 results 

      Description

      Steps to reproduce

      1. Create Asset Vocabulary
      2. Create Categories for that Vocabulary
      3. Create or update a user and assign categories
      4. Save the record and notice the categories were not saved.

      Saving Asset Tags works fine.

        Issue Links

          Activity

          Hide
          Jeffrey P. Handa added a comment -

          The problems seems to be caused by checking the actionRequest for a parameter named assetCategoryNames.

          if (actionRequest.getParameter("assetCategoryNames") == null ) {

          The actionRequest only contains actionCategoryIds. But changing the assetCategoryNames to assetCategoryIds in the above code is not enough because there may be several actionCategoryId parameters for different vocabularies.

          This step seems to be unnecessary because the actionRequestIds will already be in the ServiceContext. Removing the whole block appears to work correctly.

          Although the Asset Tags are working, the code checking the ActionRequest for the assetTagNames also seems unnecessary because the Service Context should already have that information.

          Show
          Jeffrey P. Handa added a comment - The problems seems to be caused by checking the actionRequest for a parameter named assetCategoryNames. if (actionRequest.getParameter("assetCategoryNames") == null ) { The actionRequest only contains actionCategoryIds. But changing the assetCategoryNames to assetCategoryIds in the above code is not enough because there may be several actionCategoryId parameters for different vocabularies. This step seems to be unnecessary because the actionRequestIds will already be in the ServiceContext. Removing the whole block appears to work correctly. Although the Asset Tags are working, the code checking the ActionRequest for the assetTagNames also seems unnecessary because the Service Context should already have that information.
          Hide
          Jeffrey P. Handa added a comment -

          Sergio, can you please take a look when you get some time. It looks to me like the Service Context will always have the Asset Category Ids and Asset Category Tags so there doesn't seem to be a need to try and get them from the Action Request, which was what was failing for the Asset Categories.

          Show
          Jeffrey P. Handa added a comment - Sergio, can you please take a look when you get some time. It looks to me like the Service Context will always have the Asset Category Ids and Asset Category Tags so there doesn't seem to be a need to try and get them from the Action Request, which was what was failing for the Asset Categories.
          Hide
          Jeffrey P. Handa added a comment -

          Need to make sure the solution to LPS-29781 doesn't break the solution to LPS-25410.

          Show
          Jeffrey P. Handa added a comment - Need to make sure the solution to LPS-29781 doesn't break the solution to LPS-25410 .
          Hide
          Jeffrey P. Handa added a comment -

          Tested the steps described in LPS-25410 and verified that the proposed solution works for Categories and Tags.

          Show
          Jeffrey P. Handa added a comment - Tested the steps described in LPS-25410 and verified that the proposed solution works for Categories and Tags.
          Hide
          Michael Saechang added a comment -

          Committed on:
          Portal 6.2.x GIT ID: b56d564614fd5969f0ffad11e63c2ef03c95795e.

          Show
          Michael Saechang added a comment - Committed on: Portal 6.2.x GIT ID: b56d564614fd5969f0ffad11e63c2ef03c95795e.
          Hide
          Luyang Tan (Inactive) added a comment -

          PASSED Manual Testing following the steps in the description.

          Reproduced on:
          Tomcat 7.0 + MySQL 5. Portal 6.1.20 EE GA2.

          When I click save, the category can not be saved.

          Fixed on:
          Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: 7963ca2938e9bcc0167ad92f9c98b90143edccf6.
          Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 9e92fd3ee490fb55da4898292881195ee5f8d5a4.

          When I click save, I can save the category successfully.

          Show
          Luyang Tan (Inactive) added a comment - PASSED Manual Testing following the steps in the description. Reproduced on: Tomcat 7.0 + MySQL 5. Portal 6.1.20 EE GA2. When I click save, the category can not be saved. Fixed on: Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: 7963ca2938e9bcc0167ad92f9c98b90143edccf6. Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 9e92fd3ee490fb55da4898292881195ee5f8d5a4. When I click save, I can save the category successfully.
          Hide
          Peter Mesotten added a comment -

          Is this included in one of the EE patches/fixes?

          Show
          Peter Mesotten added a comment - Is this included in one of the EE patches/fixes?
          Hide
          Lawrence Lee added a comment -

          Peter Mesotten Yes, this fix will be included in the upcoming fixpacks for 6.1 GA2

          Show
          Lawrence Lee added a comment - Peter Mesotten Yes, this fix will be included in the upcoming fixpacks for 6.1 GA2

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Days since last comment:
                2 years, 3 days ago

                Development

                  Structure Helper Panel