PUBLIC - Liferay Portal Community Edition
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-29918

Standardize coding convention for names of service impls customized in liferay-hook.xml

    Details

    • Branch Version/s:
      6.1.x
    • Backported to Branch:
      Committed
    • Similar Issues:
      Show 5 results 

      Description

      It was confusing to have kaleo-web customize com.liferay.portal.service.impl.CompanyLocalServiceImpl with com.liferay.portal.workflow.kaleo.hook.service.impl.CompanyLocalServiceImpl

      Some people didn't realize that they were 2 different classes with the same name, but different packages.

      Renamed the hook service impl to: com.liferay.portal.workflow.kaleo.hook.service.impl.KaleoCompanyLocalServiceImpl

      We'll always prefix the customized class with a prefix now so that developers don't get confused.

      This is just a coding convention.

        Activity

        Hide
        Michael Saechang added a comment -

        Committed on:
        Plugins 6.2.x GIT ID: bb75d9e49eccaa54f09181d11ad0ae19b2a3a7fc.

        Show
        Michael Saechang added a comment - Committed on: Plugins 6.2.x GIT ID: bb75d9e49eccaa54f09181d11ad0ae19b2a3a7fc.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Subcomponents

                  Structure Helper Panel