PUBLIC - Liferay Portal Community Edition
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-31111

Methods in GroupImpl that check staging settings return wrong result when staging is enabled or group is a layout scope

    Details

    • Similar Issues:
      Show 5 results 

      Description

      Staging configuration is always stored in the type settings of the parent live group. That is the group associated to the site in live.
      But the methods isStaged(), isStagedPortlet(portletId) and isStagedRemotely() are reading the typeSettings from the current group instance. So if this methods are invoked for a group instance that represents staging or a layout scope the settings are not found. Those methods should make sure that they always check the type settings of the live parent.

        Issue Links

          Activity

          Hide
          Juan Fernández added a comment -

          In order to solve the problem for all methods in a maintainable way, two methods have been added to the Group interface: getLiveParentTypeSettingsProperties() and getLiveParentTypeSettingsProperty(key) which must always be used for those settings that are always stored in the live parent group.

          This change wasn't done to the original methods because in some cases portlets may want to store (and check) settings in the staged or layout scope groups.

          Show
          Juan Fernández added a comment - In order to solve the problem for all methods in a maintainable way, two methods have been added to the Group interface: getLiveParentTypeSettingsProperties() and getLiveParentTypeSettingsProperty(key) which must always be used for those settings that are always stored in the live parent group. This change wasn't done to the original methods because in some cases portlets may want to store (and check) settings in the staged or layout scope groups.
          Hide
          Juan Fernández added a comment -

          One of the consequences of this bug was LPS-31086

          Show
          Juan Fernández added a comment - One of the consequences of this bug was LPS-31086
          Hide
          Tammy Fong (Inactive) added a comment -

          Committed on:
          Portal 6.2.x GIT ID: 7df1342740251a9168270ac9c904fb4185ab6a8e.

          Show
          Tammy Fong (Inactive) added a comment - Committed on: Portal 6.2.x GIT ID: 7df1342740251a9168270ac9c904fb4185ab6a8e.
          Hide
          Mark Jin added a comment -

          PASSED Manual Testing following the steps in the LPS-31086 description.

          Reproduced on:
          Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 8761bcd7f2d455f959381298617cb891cb73eaa7.

          Users can see the ADT appear ONLY in the dropdown menu and NOT in the popup

          Fixed on:
          Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 71213361b6c18d85c669facc1c2db7b168c9ad0f.

          Users can see the ADT appear both in the popup and in the dropdown menu.

          Show
          Mark Jin added a comment - PASSED Manual Testing following the steps in the LPS-31086 description. Reproduced on: Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 8761bcd7f2d455f959381298617cb891cb73eaa7. Users can see the ADT appear ONLY in the dropdown menu and NOT in the popup Fixed on: Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 71213361b6c18d85c669facc1c2db7b168c9ad0f. Users can see the ADT appear both in the popup and in the dropdown menu.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Days since last comment:
                2 years, 36 weeks, 5 days ago

                Development

                  Structure Helper Panel