DL API to move file includes mandatory field in serviceContext

• Type: Bug
• Status: Closed
• Resolution: Won't Fix
• Affects Version/s: 6.1.1 CE GA2, 6.1.20 EE GA2
• Fix Version/s: --Sprint 11/12, 6.2.0 CE M2
• Component/s: DM, DM > Document Library Display, Portal Services > Legacy
• Labels: None
• Fix Priority: 3
• Where was the bug?:
  Java

DL service calls to move file entry requires serviceContext.scopeGroupId to be filled if moving to default parent folder. Mandatory fields should not be in serviceContext.

	protected Repository getRepository(
			long folderId, ServiceContext serviceContext)
		throws PortalException, SystemException {

		Repository repository = null;

		if (folderId == DLFolderConstants.DEFAULT_PARENT_FOLDER_ID) {
			repository = getRepository(serviceContext.getScopeGroupId());
		}
		else {
			repository = getRepository(folderId, 0, 0);
		}

		return repository;
	}

[Igor Spasic]

serviceContext.scopeGroupId is still needed for further execution (used by permission checker, and maybe later as well), so I am setting it up in the code when target folder is 0 (default)

[Alexander Chow (Inactive)]

Updated the pull request to clean up scopeGroupId in DL

[Jorge Ferrer]

Closing this as "Won't fix" for now. See comments at https://github.com/JorgeFerrer/liferay-portal/pull/117 for details.