PUBLIC - Liferay Portal Community Edition
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-32191

As a user selecting parent organization I will see available organizations in dialog window

    Details

    • Epic/Theme:
    • Where was the bug?:
      JSP, Javascript
    • Similar Issues:
      Show 4 results 

      Description

      Who will benefit: organization administrator user
      What is benefit: dialog windows have better UX and are easier to manage from parent window than popup windows

      Edit organization view in Users and Organizations, Configuration views in Recent Blogers and Blogs Agregator provide Administrator User with ability to select parent organization via POPUP window. Since we can't position POPUP or make it look as part of parent page it would be good to implement it as Dialog.

      Affected sources:

      portal-web/docroot/html/portlet/blogs_aggregator/configuration.jsp
      portal-web/docroot/html/portlet/recent_bloggers/configuration.jsp
      portal-web/docroot/html/portlet/users_admin/organization/details.jsp
      portal-web/docroot/html/portlet/users_admin/select_organization.jsp
      

        Issue Links

          Activity

          Hide
          Igor Beslic added a comment -

          I asked Iliyan about this:
          On Thu, 27 Dec 2012 08:25:28 +0100, Igor Beslic <igor.beslic@liferay.com> wrote:

          Hi Iliyan,
          when editing an organization, user selects parent organization by clicking Select link:

          /html/portlet/users_admin/organization/details.jsp

          implements

          function <portlet:namespace />openOrganizationSelector() {
          		var url = '<portlet:renderURL windowState="<%= LiferayWindowState.POP_UP.toString() %>"><portlet:param name="struts_action" value="/users_admin/select_organization" /></portlet:renderURL>';
          

          I wonder do you think it could be good to create improvement ticket to convert IFrame to Dialog. I'm fixing http://issues.liferay.com/browse/LPS-30448 and maybe I can do it since I'm familiar with that code now?

          Answer:

          Sure - as less iframes we have, as better.

          Thanks,
          Iliyan

          Show
          Igor Beslic added a comment - I asked Iliyan about this: On Thu, 27 Dec 2012 08:25:28 +0100, Igor Beslic <igor.beslic@liferay.com> wrote: Hi Iliyan, when editing an organization, user selects parent organization by clicking Select link: /html/portlet/users_admin/organization/details.jsp implements function <portlet:namespace />openOrganizationSelector() { var url = '<portlet:renderURL windowState= "<%= LiferayWindowState.POP_UP.toString() %>" ><portlet:param name= "struts_action" value= "/users_admin/select_organization" /></portlet:renderURL>'; I wonder do you think it could be good to create improvement ticket to convert IFrame to Dialog. I'm fixing http://issues.liferay.com/browse/LPS-30448 and maybe I can do it since I'm familiar with that code now? Answer: Sure - as less iframes we have, as better. Thanks, Iliyan
          Hide
          Igor Beslic added a comment -

          Iliyan please review my work.

          Show
          Igor Beslic added a comment - Iliyan please review my work.
          Hide
          Igor Beslic added a comment -

          Hi Iliyan here is https://github.com/ipeychev/liferay-portal/pull/113

          Also this is the 1st way to test:

          • go to Control Panel/User and Organizations
          • create 3 organizations: org1, org2 and org3
          • from Action menu for org1 choose Edit
          • scroll to the bottom to parent organization selection
          • click link Select
          • when dialog is loaded try to click link Advanced - nothing will happen, you wont be able to toggle advanced basic search

          2nd way to test

          • add one of Blog Agregator or Recent Bloggers portlets
          • go to portlet configuration
          • in Organization definition, click select
          • when dialog is loaded try to click link Advanced - nothing will happen, you wont be able to toggle advanced basic search

          Iliyan, thanks for help, please feel free to contact me for any additional info you need.

          Show
          Igor Beslic added a comment - Hi Iliyan here is https://github.com/ipeychev/liferay-portal/pull/113 Also this is the 1st way to test: go to Control Panel/User and Organizations create 3 organizations: org1, org2 and org3 from Action menu for org1 choose Edit scroll to the bottom to parent organization selection click link Select when dialog is loaded try to click link Advanced - nothing will happen, you wont be able to toggle advanced basic search 2nd way to test add one of Blog Agregator or Recent Bloggers portlets go to portlet configuration in Organization definition, click select when dialog is loaded try to click link Advanced - nothing will happen, you wont be able to toggle advanced basic search Iliyan, thanks for help, please feel free to contact me for any additional info you need.
          Hide
          Igor Beslic added a comment -

          Hi Iliyan here is new PR.

          Show
          Igor Beslic added a comment - Hi Iliyan here is new PR.
          Hide
          Albert Lee added a comment -

          PASSED Manual Testing using the following steps:

          1. Add the Blogs Aggregator and Recent Bloggers portlet to a page
          2. Blogs Aggregator
            1. Click on Configuration > Setup
            2. Under Organization, click the Select button
            3. Assert "Select Organization" dialog box displays
          3. Recent Bloggers
            1. Click on Configuration > Setup
            2. Under Organization, click the Select button
            3. Assert "Select Organization" dialog box displays

          Passed on:
          Tomcat 7 + MySQL 5. Portal 6.2.x: f2daa5a19c7e94692261597d31fc51e28b4965c1.

          Show
          Albert Lee added a comment - PASSED Manual Testing using the following steps: Add the Blogs Aggregator and Recent Bloggers portlet to a page Blogs Aggregator Click on Configuration > Setup Under Organization, click the Select button Assert "Select Organization" dialog box displays Recent Bloggers Click on Configuration > Setup Under Organization, click the Select button Assert "Select Organization" dialog box displays Passed on: Tomcat 7 + MySQL 5. Portal 6.2.x: f2daa5a19c7e94692261597d31fc51e28b4965c1.
          Hide
          Kenji Heigel added a comment -

          PASSED Manual Testing using the following steps:

          1. Go to > Control Panel > Users and Organizations
          2. Click Add > Regular Organization and add org1, org2 and org3
          3. Click View Organizations and click Actions next to org1
          4. Click Select under Parent Organization
          5. Click Advanced in the search box of the Select Organization popup.

          Passed on:
          Tomcat 7.0.34 + MySQL 5. Portal 6.2.x GIT ID: dda4f5797eddcbe96c0d86a0a9598fa8cf2acb44.

          The toggle between advanced and basic search works. Existing organizations are also visible in the popup window.

          Show
          Kenji Heigel added a comment - PASSED Manual Testing using the following steps: Go to > Control Panel > Users and Organizations Click Add > Regular Organization and add org1, org2 and org3 Click View Organizations and click Actions next to org1 Click Select under Parent Organization Click Advanced in the search box of the Select Organization popup. Passed on: Tomcat 7.0.34 + MySQL 5. Portal 6.2.x GIT ID: dda4f5797eddcbe96c0d86a0a9598fa8cf2acb44. The toggle between advanced and basic search works. Existing organizations are also visible in the popup window.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development

                  Structure Helper Panel