Details

    • Branch Version/s:
      6.1.x
    • Backported to Branch:
      Committed
    • Story Points:
      4
    • Fix Priority:
      4

      Description

      When rendering the layout template in the customization section of the Manage Pages dialog, we should prevent it from including invasive markup—especially whole portlets included via theme.runtime(...).

        Issue Links

          Activity

          Hide
          raymond.auge Raymond Auge added a comment -

          The complete fix prevents all methods of the VelocityTagLib class from executing by replacing it with a dummy impl.

          Show
          raymond.auge Raymond Auge added a comment - The complete fix prevents all methods of the VelocityTagLib class from executing by replacing it with a dummy impl.
          Hide
          yang.gao Yang Gao (Inactive) added a comment -

          PASSED Manual Testing using the following steps:

          1. Go to ROOT/layouttpl/custom/2_columns_ii.tpl and add $theme.runtime("3") below table in one of the columns.
          2. Start bundle.
          3. Go to Control Panel > Site Pages > Welcome > Customization Settings.
          4. Add a Child Page and Save.
          5. Change the title of it and click Save.

          Reproduced on:
          Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: de26ce70128ccd5c9483da3b6b994c1d8960ebfc.

          It will not save the changing.

          Fixed on:
          Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: d124ed43d4286fc9115474490275bbaf8311bc00.
          Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 8b3d3bc1f59cd7a6efcedc8ac83a779c54b2e211.

          It will save the changing.

          Show
          yang.gao Yang Gao (Inactive) added a comment - PASSED Manual Testing using the following steps: 1. Go to ROOT/layouttpl/custom/2_columns_ii.tpl and add $theme.runtime("3") below table in one of the columns. 2. Start bundle. 3. Go to Control Panel > Site Pages > Welcome > Customization Settings. 4. Add a Child Page and Save. 5. Change the title of it and click Save. Reproduced on: Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: de26ce70128ccd5c9483da3b6b994c1d8960ebfc. It will not save the changing. Fixed on: Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: d124ed43d4286fc9115474490275bbaf8311bc00. Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 8b3d3bc1f59cd7a6efcedc8ac83a779c54b2e211. It will save the changing.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Days since last comment:
                4 years, 12 weeks, 2 days ago

                Development

                  Subcomponents