Details

    • Similar Issues:
      Show 5 results 

      Description

      In asset publisher, I found if only one scope (layout_1) is chose, the value of defaultscope is set to layout_1. If there are multiple scopes are chose, the defaultScope = false and scopeIds gets all scope values.

      It is even confusing in getGroupIds method of AssetPublisherUtil.java, the value of defaultScope in portletPreferences is passing to defaultScopeId and defaultScopeId could be true and false which should be scopes' id in the literal sense.

      It will be more clear to confine the value of defaultScope as boolean and let scopeIds store all the scopes' id.

        Issue Links

          Activity

          Hide
          Sherry Yang added a comment -

          I made a code changes https://github.com/sherryre/liferay-portal/commit/9e645199160d16d46e46f2a8de7b2fb112e83e31

          What I did is renamed preferences-defaultScope- as preferences-scopeId- and passed the actual scopeId values to it.

          "setScope" method in ConfigurationActionImpl is called when only one scope is selected, save scopeId to scopeIds and set the defaultScope to true."addScope" method is call when multiple scopes are selected and set defaultScope to false.

          As a result, DefaultScope is changed to boolean type, and what more, I made the changes in getGroupIds in AssetPublisherUtil accordingly.

          It was working several days ago, however, malfunctioned due to the changes in the trunk on asset publisher. I believe someone is working on the UI changes for scopes. It is better to escalate.

          Show
          Sherry Yang added a comment - I made a code changes https://github.com/sherryre/liferay-portal/commit/9e645199160d16d46e46f2a8de7b2fb112e83e31 What I did is renamed preferences- defaultScope - as preferences- scopeId - and passed the actual scopeId values to it. "setScope" method in ConfigurationActionImpl is called when only one scope is selected, save scopeId to scopeIds and set the defaultScope to true."addScope" method is call when multiple scopes are selected and set defaultScope to false. As a result, DefaultScope is changed to boolean type, and what more, I made the changes in getGroupIds in AssetPublisherUtil accordingly. It was working several days ago, however, malfunctioned due to the changes in the trunk on asset publisher. I believe someone is working on the UI changes for scopes. It is better to escalate.
          Hide
          Sherry Yang added a comment -

          It is related to LPS-32132. The fix for LPS-32132 need to base on it.

          Show
          Sherry Yang added a comment - It is related to LPS-32132 . The fix for LPS-32132 need to base on it.
          Hide
          Randy Zhu added a comment -

          In preparation for Ideation; we are merging New Feature and Improvement tickets into a singular ticket type called “Feature Request”. Additional information to follow soon.

          Show
          Randy Zhu added a comment - In preparation for Ideation; we are merging New Feature and Improvement tickets into a singular ticket type called “Feature Request”. Additional information to follow soon.

            People

            • Assignee:
              Julio Camarero
              Reporter:
              Sherry Yang
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:

                Development

                  Structure Helper Panel