Activity Interpreters show trash activities and activities on trashed items incorrectly

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 6.2.0 CE M4
• Fix Version/s: 6.2.0 CE M5
• Component/s: Social Networking, Social Networking > Activities, WCM, WCM > Recycle Bin
• Labels:
  • QA-R
  • QA-TP
• Story Points: 3
• Fix Priority: 3

With the introduction of the trash, activity interpreters need to be updated to accommodate new activities, such as MOVE_TO_TRASH and RESTORE_FROM_TRASH. Also when certain models are trashed, their titles are replaced by a temporary construct and as a result activities show the titles of these items incorrectly. Additionally, when an item is in the trash, the link to show the item should be replaced to point to the trash portlet, because the original portlets will not be able to show the item and will throw exceptions.

[Zsolt Berentey (Inactive)]

This was inadvertently closed because of a wrong LPS reference in a commit...

[Serena Song (Inactive)]

PASSED Manual Testing using the following steps:

1. Start Liferay instance.
2. Add a page and add bookmark portlet to the page.
3. Add a folder in the bookmark portlet.
4. Move the folder to recycle bin.
5. Go to control panel.
6. Click recycle bin and restore the folder that you move.
7. Navigate to the database.
8. See if the activity has been added to the SocialActivity table.

Reproduced on:
Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: bd2764ac35a85d98bd73808c6631cd3fd14b974c.

The console will throw the exception:

06:47:46,087 ERROR [com.liferay.portlet.layoutconfiguration.util.RuntimePageImpl-1][IncludeTag:205] Current URL /web/guest/home generates exception: com.liferay.portal.NoSuchPortletPreferencesException: No PortletPreferences exists with the key {ownerId=0, ownerType=3, plid=10168, portletId=101_USER_2_INSTANCE_Dq91jkKrFiqo}
06:47:46,104 ERROR [com.liferay.portlet.layoutconfiguration.util.RuntimePageImpl-1][IncludeTag:154] com.liferay.portal.NoSuchPortletPreferencesException: No PortletPreferences exists with the key {ownerId=0, ownerType=3, plid=10168, portletId=101_USER_2_INSTANCE_Dq91jkKrFiqo}
	at com.liferay.portal.service.persistence.PortletPreferencesPersistenceImpl.findByO_O_P_P(PortletPreferencesPersistenceImpl.java:2870)
	at com.liferay.portal.service.impl.PortletPreferencesLocalServiceImpl.getPortletPreferences(PortletPreferencesLocalServiceImpl.java:154)
	at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:112)
	at com.liferay.portal.service.impl.PortletPreferencesLocalServiceStagingAdvice.getPortletPreferences(PortletPreferencesLocalServiceStagingAdvice.java:99)
	at com.liferay.portal.service.impl.PortletPreferencesLocalServiceStagingAdvice.invoke(PortletPreferencesLocalServiceStagingAdvice.java:62)
	at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:108)
	at com.liferay.portal.spring.transaction.TransactionInterceptor.invoke(TransactionInterceptor.java:80)
	at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:108)
	at com.liferay.portal.spring.aop.ServiceBeanAopProxy.invoke(ServiceBeanAopProxy.java:162)
	at com.liferay.portal.service.PortletPreferencesLocalServiceUtil.getPortletPreferences(PortletPreferencesLocalServiceUtil.java:311)
	at com.liferay.portlet.assetpublisher.util.AssetPublisherUtil._getPortletPreferencesId(AssetPublisherUtil.java:1063)
	at com.liferay.portlet.assetpublisher.util.AssetPublisherUtil.isSubscribed(AssetPublisherUtil.java:847)
	at org.apache.jsp.html.portlet.asset_005fpublisher.view_jsp._jspService(view_jsp.java:1185)
	at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
	at com.liferay.portal.servlet.DirectRequestDispatcher.include(DirectRequestDispatcher.java:55)
	at com.liferay.taglib.util.IncludeTag.include(IncludeTag.java:295)
	at com.liferay.taglib.util.IncludeTag.doInclude(IncludeTag.java:199)
	at com.liferay.taglib.util.IncludeTag.doEndTag(IncludeTag.java:81)
	at org.apache.jsp.html.common.themes.portlet_jsp._jspService(portlet_jsp.java:3829)

08:57:54,358 INFO  [pool-2-thread-1][DialectDetector:71] Determine dialect for MySQL 5
08:57:54,419 INFO  [pool-2-thread-1][DialectDetector:136] Found dialect org.hibernate.dialect.MySQLDialect
08:58:18,163 INFO  [pool-2-thread-1][BaseDB:456] Database does not support case sensitive queries
08:58:18,630 INFO  [pool-2-thread-1][ServerDetector:166] Server supports hot deploy
08:58:18,643 INFO  [pool-2-thread-1][PluginPackageUtil:1028] Reading plugin package for the root context
08:58:34,446 INFO  [pool-2-thread-1][AutoDeployDir:99] Auto deploy scanner started for D:\Git\Liferay-Portal-ee\bundles\tomcat\62\trunk\deploy
09:00:41,650 ERROR [com.liferay.portlet.layoutconfiguration.util.RuntimePageImpl-1][IncludeTag:205] Current URL / generates exception: javax.servlet.ServletException: com.liferay.portal.NoSuchPortletPreferencesException: No PortletPreferences exists with the key {ownerId=0, ownerType=3, plid=10168, portletId=101_USER_2_INSTANCE_Dq91jkKrFiqo}
09:00:41,659 ERROR [com.liferay.portlet.layoutconfiguration.util.RuntimePageImpl-1][IncludeTag:154] com.liferay.portal.NoSuchPortletPreferencesException: No PortletPreferences exists with the key {ownerId=0, ownerType=3, plid=10168, portletId=101_USER_2_INSTANCE_Dq91jkKrFiqo}
	at com.liferay.portal.service.persistence.PortletPreferencesPersistenceImpl.findByO_O_P_P(PortletPreferencesPersistenceImpl.java:2870)
	at com.liferay.portal.service.impl.PortletPreferencesLocalServiceImpl.getPortletPreferences(PortletPreferencesLocalServiceImpl.java:154)
	at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:112)
	at com.liferay.portal.service.impl.PortletPreferencesLocalServiceStagingAdvice.getPortletPreferences(PortletPreferencesLocalServiceStagingAdvice.java:99)
	at com.liferay.portal.service.impl.PortletPreferencesLocalServiceStagingAdvice.invoke(PortletPreferencesLocalServiceStagingAdvice.java:62)
	at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:108)
	at com.liferay.portal.spring.transaction.TransactionInterceptor.invoke(TransactionInterceptor.java:80)
	at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:108)
	at com.liferay.portal.spring.aop.ChainableMethodAdvice.invoke(ChainableMethodAdvice.java:55)
	at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:108)
	at com.liferay.portal.spring.aop.ChainableMethodAdvice.invoke(ChainableMethodAdvice.java:55)
	at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:108)
	at com.liferay.portal.spring.aop.ChainableMethodAdvice.invoke(ChainableMethodAdvice.java:55)
	at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:108)
	at com.liferay.portal.spring.aop.ChainableMethodAdvice.invoke(ChainableMethodAdvice.java:55)
	at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:108)
	at com.liferay.portal.spring.aop.ChainableMethodAdvice.invoke(ChainableMethodAdvice.java:55)
	at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:108)
	at com.liferay.portal.spring.aop.ServiceBeanAopProxy.invoke(ServiceBeanAopProxy.java:162)
	at com.liferay.portal.service.PortletPreferencesLocalServiceUtil.getPortletPreferences(PortletPreferencesLocalServiceUtil.java:311)

09:00:41,810 INFO  [com.liferay.portal.plugin.PluginPackageUtil][PluginPackageUtil:1424] Checking for available updates
09:00:41,813 INFO  [com.liferay.portal.plugin.PluginPackageUtil][PluginPackageUtil:1468] Finished checking for available updates in 0 ms
09:30:02,561 INFO  [pool-2-thread-1][DialectDetector:71] Determine dialect for MySQL 5
09:30:02,634 INFO  [pool-2-thread-1][DialectDetector:136] Found dialect org.hibernate.dialect.MySQLDialect
09:30:26,255 ERROR [pool-2-thread-1][JDBCExceptionReporter:76] Table 'serenatrunk.lock_' doesn't exist
09:30:27,034 WARN  [pool-2-thread-1][ReleaseLocalServiceImpl:173] Table 'serenatrunk.release_' doesn't exist
09:30:27,038 INFO  [pool-2-thread-1][ReleaseLocalServiceImpl:83] Create tables and populate with default data
09:30:50,363 INFO  [pool-2-thread-1][BaseDB:456] Database does not support case sensitive queries
09:30:51,482 INFO  [pool-2-thread-1][VerifyProcess:55] Verifying com.liferay.portal.verify.VerifyProcessSuite
09:30:51,485 INFO  [pool-2-thread-1][VerifyProcess:55] Verifying com.liferay.portal.verify.VerifyProperties
09:30:51,498 INFO  [pool-2-thread-1][VerifyProcess:55] Verifying com.liferay.portal.verify.VerifyDB2
09:30:51,499 INFO  [pool-2-thread-1][VerifyProcess:55] Verifying com.liferay.portal.verify.VerifyMySQL
09:30:51,541 INFO  [pool-2-thread-1][VerifyProcess:55] Verifying com.liferay.portal.verify.VerifyOracle
09:30:51,545 INFO  [pool-2-thread-1][VerifyProcess:55] Verifying com.liferay.portal.verify.VerifySQLServer
09:30:51,557 INFO  [pool-2-thread-1][VerifyProcess:55] Verifying com.liferay.portal.verify.VerifyUUID
09:30:51,569 INFO  [pool-2-thread-1][VerifyProcess:55] Verifying com.liferay.portal.verify.VerifyPermission
09:30:53,522 INFO  [pool-2-thread-1][VerifyProcess:55] Verifying com.liferay.portal.verify.VerifyRole
09:30:53,525 INFO  [pool-2-thread-1][VerifyProcess:55] Verifying com.liferay.portal.verify.VerifyAsset
09:30:53,535 INFO  [pool-2-thread-1][UpgradeProcess:175] Upgrading com.liferay.portal.upgrade.util.UpgradeAssetPublisherManualEntries
09:30:53,539 INFO  [pool-2-thread-1][VerifyProcess:55] Verifying com.liferay.portal.verify.VerifyBlogs
09:30:53,556 INFO  [pool-2-thread-1][VerifyProcess:55] Verifying com.liferay.portal.verify.VerifyBookmarks
09:30:53,569 INFO  [pool-2-thread-1][VerifyProcess:55] Verifying com.liferay.portal.verify.VerifyCalendar
09:30:53,581 INFO  [pool-2-thread-1][VerifyProcess:55] Verifying com.liferay.portal.verify.VerifyDocumentLibrary
09:30:53,643 INFO  [pool-2-thread-1][VerifyProcess:55] Verifying com.liferay.portal.verify.VerifyGroup
09:30:55,269 INFO  [pool-2-thread-1][VerifyProcess:55] Verifying com.liferay.portal.verify.VerifyJournal
09:30:55,293 INFO  [pool-2-thread-1][VerifyProcess:55] Verifying com.liferay.portal.verify.VerifyLayout
09:30:55,333 INFO  [pool-2-thread-1][VerifyProcess:55] Verifying com.liferay.portal.verify.VerifyMessageBoards
09:30:55,371 INFO  [pool-2-thread-1][VerifyProcess:55] Verifying com.liferay.portal.verify.VerifyOrganization
09:30:55,375 INFO  [pool-2-thread-1][VerifyProcess:55] Verifying com.liferay.portal.verify.VerifyResourcePermissions
09:30:55,382 INFO  [pool-2-thread-1][VerifyProcess:55] Verifying com.liferay.portal.verify.VerifySocial
09:30:55,384 INFO  [pool-2-thread-1][VerifyProcess:55] Verifying com.liferay.portal.verify.VerifyUser
09:30:55,416 INFO  [pool-2-thread-1][VerifyProcess:55] Verifying com.liferay.portal.verify.VerifyWiki
09:30:55,427 INFO  [pool-2-thread-1][VerifyProcess:55] Verifying com.liferay.portal.verify.VerifyWorkflow
09:30:55,502 INFO  [pool-2-thread-1][ServerDetector:166] Server supports hot deploy
09:30:55,516 INFO  [pool-2-thread-1][PluginPackageUtil:1028] Reading plugin package for the root context
09:31:11,174 INFO  [pool-2-thread-1][AutoDeployDir:99] Auto deploy scanner started for D:\Git\Liferay-Portal-ee\bundles\tomcat\62\trunk\deploy
09:31:29,669 INFO  [com.liferay.portal.plugin.PluginPackageUtil][PluginPackageUtil:1424] Checking for available updates
09:31:29,671 INFO  [com.liferay.portal.plugin.PluginPackageUtil][PluginPackageUtil:1468] Finished checking for available updates in 0 ms

Fixed on:
Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 9776027b3f68b4c770c624001c26cbdeee2702ed.

No error or exception displays in the console.