Details

    • Similar Issues:
      Show 5 results 

      Description

      The aim of the root element refactoring is to provide a way for the staged model data handlers and portlet data handlers to reach the portlet-data.xml file's root element from anywhere in the code.

      In some cases if a portlet-data.xml is organized in a flat structure like this example:

      <XYPortletDataHandler>
         <test-entities>
            <test />
         </test-entities>
         <different-entities>
            <different-entity />
         </different-entities>
      </XYPortletDataHandler>
      

      First the XYPortletDataHandler picks up the processing and passes the control flow over the staged model data handler for the test entity. As the test entity staged model data handler wants to import the referenced "different entities" it couldn't reach the grouping xml element since the staged model data handler cannot reach the root element for the portlet-data.xml file.
      Most of the portlets are organized in this flat structure, so the root element should be accessible to the participants in the staging.

      There is also one bug related to the portlet-data.xml caused in this ticket: LPS-32861
      With the changes in the mentioned ticket, there is no xml opening tag being generated in the portlet-data.xml files, so when trying to import the portlet data handlers will bypass the import because the xml file is not valid.

        Issue Links

          Activity

          Show
          Brian Chan added a comment - See https://github.com/brianchandotcom/liferay-portal/pull/9625
          Hide
          Mate Thurzo added a comment -

          Move to the correct status, since this has been merged to the trunk already.

          Show
          Mate Thurzo added a comment - Move to the correct status, since this has been merged to the trunk already.
          Hide
          Evan Nagayama added a comment -

          Closing as cannot be tested by QA, as ticket deals primarily with the backend. Please see comment on LPS-35003.

          Show
          Evan Nagayama added a comment - Closing as cannot be tested by QA, as ticket deals primarily with the backend. Please see comment on LPS-35003 .

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Days since last comment:
                2 years, 1 week, 5 days ago

                Development

                  Structure Helper Panel