Kaleo - Every non-initial state considered terminal state when parsing a workflow xml

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 6.1.1 CE GA2, 6.1.20 EE GA2
• Fix Version/s: 6.1.2 CE GA3, 6.1.30 EE GA3, 6.2.0 CE M5
• Component/s: Workflow, Workflow > API > Kaleo Engine
• Labels:
  • QA-R
  • QA-TP
  • ee-ts
  • eu-support
  • kaleo
• Branch Version/s:
  6.1.x
• Backported to Branch:
  Committed
• Story Points: 4
• Git Pull Request: https://github.com/brianchandotcom/liferay-plugins/pull/1356

When we parse a workflow xml, every state which isn't initial state considered terminal state, because it is determined by the states outgoing transitions, and when that happens the transitions aren't parsed yet.

Steps to reproduce:
Create a workflow with multiple non-initial states and debug during save. (they aren't saved to the database as terminal nodes, but it can case problems during validation).