Kaleo - Every non-initial state considered terminal state when parsing a workflow xml

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 6.1.1 CE GA2, 6.1.20 EE GA2
• Fix Version/s: 6.1.2 CE GA3, 6.1.30 EE GA3, 6.2.0 CE M5
• Component/s: Workflow, Workflow > API > Kaleo Engine
• Labels:
  • QA-R
  • QA-TP
  • ee-ts
  • eu-support
  • kaleo
• Branch Version/s:
  6.1.x
• Backported to Branch:
  Committed
• Story Points: 4

When we parse a workflow xml, every state which isn't initial state considered terminal state, because it is determined by the states outgoing transitions, and when that happens the transitions aren't parsed yet.

Steps to reproduce:
Create a workflow with multiple non-initial states and debug during save. (they aren't saved to the database as terminal nodes, but it can case problems during validation).

[Pani Gui (Inactive)]

PASSED Manual Testing using the following steps:

1. Start portal.
2. Deploy Kaleo-upgrade-hook, Kaleo-web, Kaleo-designer-portlet and Kaleo-forms-portlet.
3. Add Kaleo Forms portlet to a page.
4. Click Processes tab -> Add.
5. Select an entry to Entry Definition.
6. Select a form for the entry to Initial Form.
7. Click Select under Workflow.
8. Click Add Definition button.
9. Fill in name and title.
10. Drag Task, State(1) and State(2) nodes to view page and link them.
Start -> Task -> State(1) -> End.
Start -> Task -> State(2) -> End.
11. Click Add Draft button.
It's unable to be saved.
12. Go to Control Panel > Workflow.
13. Click Add.
14. Fill in title and upload a workflow xml with multiple non-initial states.
15. Click Save button.

Reproduced on:
Tomcat 7.0 + MySQL 5. Portal 6.1.20 EE GA2.

Workflow with multiple non-initial states can not be saved.

Fixed on:
Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: f6bfdf784b571ea7b692c3b4b2215e5b03b5b32e.
Plugins 6.1.x EE GIT ID: aa3099773dda0c58ec3d524f7ab95c961be22101.
Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 8e27906acc1a59e60b6bfdb4dd83c6424979cd6f.
Plugins 6.2.x EE GIT ID: 82563d1c865ac0466d9177a1a73de98e0d080aaf.

It can be saved successfully.