Details

    • Branch Version/s:
      6.1.x
    • Backported to Branch:
      Committed
    • Fix Priority:
      4
    • Similar Issues:
      Show 5 results 

      Description

      Steps to reproduce:

      1. Go to Control Panel -> Plugins Configuration -> Layout Template Plugins
      2. Edit an arbitrary template, e.g. the "1 column" template by clicking on its link
      3. Uncheck 'active'
      4. Click 'Save'
      5. The layout still appears to be 'active' in the list
      6. Reopen the layout by clicking its link
      7. Verify that the active checkbox is unchecked
      8. Open a page's layout settings (Dockbar/Manage/Page layout) and verify that you can still select the "1 column" layout template

        Activity

        Hide
        Pani Gui (Inactive) added a comment -

        PASSED Manual Testing following the steps in the description.

        Reproduced on:
        Tomcat 7.0 + MySQL 5. Portal 6.1.20 EE GA2.

        Layout template plugins can not be deactivated.

        Fixed on:
        Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: 26f55bc6464503acc0dc8534f7666f21e3b52503.
        Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 090754c32bac4bcd8984ea1bbc5e59fec056a845.

        Layout template plugins can be deactivated properly.

        Show
        Pani Gui (Inactive) added a comment - PASSED Manual Testing following the steps in the description. Reproduced on: Tomcat 7.0 + MySQL 5. Portal 6.1.20 EE GA2. Layout template plugins can not be deactivated. Fixed on: Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: 26f55bc6464503acc0dc8534f7666f21e3b52503. Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 090754c32bac4bcd8984ea1bbc5e59fec056a845. Layout template plugins can be deactivated properly.
        Hide
        Tibor Lipusz added a comment - - edited

        Tibor wrote on 3/19/2013

        Hi Brian, Nate,

        I've just realized that my original pull request for LPS-33712 (https://github.com/natecavanaugh/liferay-portal/pull/1072) was merged & forwarded under a new LPS-number & message: "LPS-33476 - XSS Vlunerabilities in Portal Settings Home URL"

        And, it was commited to trunk: https://github.com/brianchandotcom/liferay-portal/compare/2c574ab6c7...3a2eddf692

        Despite both LPS tickets are closed now, I think this state could cause problems in the future when somebody will try to cherry-pick or grep my commit for LPS-33712.

        Is it normal or can you please update it?

        Thanks,
        Tibor

        Show
        Tibor Lipusz added a comment - - edited Tibor wrote on 3/19/2013 Hi Brian, Nate, I've just realized that my original pull request for LPS-33712 ( https://github.com/natecavanaugh/liferay-portal/pull/1072 ) was merged & forwarded under a new LPS-number & message: "LPS-33476 - XSS Vlunerabilities in Portal Settings Home URL" And, it was commited to trunk: https://github.com/brianchandotcom/liferay-portal/compare/2c574ab6c7...3a2eddf692 Despite both LPS tickets are closed now, I think this state could cause problems in the future when somebody will try to cherry-pick or grep my commit for LPS-33712 . Is it normal or can you please update it? Thanks, Tibor
        Hide
        Sophia Zhang added a comment -

        Will close it if Brian or Nate update this ticket.

        Show
        Sophia Zhang added a comment - Will close it if Brian or Nate update this ticket.
        Hide
        Tibor Lipusz added a comment - - edited

        @Nate wrote on 3/20/2013

        Hi Tibor,
        Sorry about that. I believe that one was my fault. When I originally pulled down the branch, it was saying that there was no commit message for your commit. I must have added the wrong one on top of it.

        We can't rewrite the history, but I've sent Brian a new pull reverting the bad commit, and readding it with the proper commit message.
        That pull is here: https://github.com/brianchandotcom/liferay-portal/pull/9803

        Sorry about that!

        Show
        Tibor Lipusz added a comment - - edited @Nate wrote on 3/20/2013 Hi Tibor, Sorry about that. I believe that one was my fault. When I originally pulled down the branch, it was saying that there was no commit message for your commit. I must have added the wrong one on top of it. We can't rewrite the history, but I've sent Brian a new pull reverting the bad commit, and readding it with the proper commit message. That pull is here: https://github.com/brianchandotcom/liferay-portal/pull/9803 Sorry about that!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Days since last comment:
              2 years, 1 week, 6 days ago

              Development

                Structure Helper Panel