PUBLIC - Liferay Portal Community Edition
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-33802

When disabling staging AssetTags of the deleted group remain in the database

    Details

    • Branch Version/s:
      6.1.x
    • Backported to Branch:
      Committed
    • Story Points:
      5
    • Fix Priority:
      3
    • Similar Issues:
      Show 5 results 

      Description

      Reproduction steps:

      1. Add at least one page on a site
      2. Add a web content
      3. Add a tag to the web content you just created
      4. Enable staging on the site
      5. Record the groupId of the Staging site
      6. Check if all the contents are replicated for the staging group
      7. Disable staging
      8. Query the AssetTag table from the database specifying the groupId recorded in step 5.

      Expected behavior: No result is returned by the query
      Actual behavior: asset tags listed for the deleted group

        Issue Links

          Activity

          Hide
          Mate Thurzo added a comment -

          Vilmos,

          I've closed the PR for some reason but I have no recollection of why. Can you please check on the latest trunk is this is still a problem?

          If so can you please re-send the changes to me?

          Show
          Mate Thurzo added a comment - Vilmos, I've closed the PR for some reason but I have no recollection of why. Can you please check on the latest trunk is this is still a problem? If so can you please re-send the changes to me?
          Hide
          Vilmos Papp added a comment -

          Hi Máté,

          As it is sill an issue, I've resent the pull request for you.

          Show
          Vilmos Papp added a comment - Hi Máté, As it is sill an issue, I've resent the pull request for you.
          Hide
          Ginson Ren added a comment -

          PASSED Manual Testing following the steps in the description.

          Reproduced on:
          Tomcat 7.0 + MySQL 5. Portal 6.1.20 EE GA2.

          The Staging group still record in the table.

          Fixed on:
          Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: a9b7c09e9dc70bc53c1241ac9628b7ff32a923aa.

          After disabling staging, the Staging group was deleted from the table.

          Show
          Ginson Ren added a comment - PASSED Manual Testing following the steps in the description. Reproduced on: Tomcat 7.0 + MySQL 5. Portal 6.1.20 EE GA2. The Staging group still record in the table. Fixed on: Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: a9b7c09e9dc70bc53c1241ac9628b7ff32a923aa. After disabling staging, the Staging group was deleted from the table.
          Hide
          Dustin Ryerson added a comment -

          The backport to ee-6.1.x puts the logic of the deleteGroupTags#AssetTagLocalServiceImpl (added in master 67b89bdbfde15c058e4eabd12c765b0ba160448b) directly into GroupLocalServceImpl to avoid adding a new method to the AssetTagLocalService interface and potentially breaking backward compat for clients.

          Show
          Dustin Ryerson added a comment - The backport to ee-6.1.x puts the logic of the deleteGroupTags#AssetTagLocalServiceImpl (added in master 67b89bdbfde15c058e4eabd12c765b0ba160448b) directly into GroupLocalServceImpl to avoid adding a new method to the AssetTagLocalService interface and potentially breaking backward compat for clients.
          Hide
          Sharry Shi added a comment -

          FAILED Manual Testing following the steps in the description.

          Reproduced on:
          Tomcat 7.0.27 + MySQL 5.5.21 Portal 6.1.30 EE GA3.

          The data in AssetTag table still exists after the staged group was deleted.

          Failed on:
          Tomcat 7.0.40 + MySQL 5.5.21 Portal 6.1.x.EE GIT ID: 91e70a8331f537382702d5dd978106ea1392b9bc.

          The data in AssetTag table still exists after the staged group was deleted.

          Show
          Sharry Shi added a comment - FAILED Manual Testing following the steps in the description. Reproduced on: Tomcat 7.0.27 + MySQL 5.5.21 Portal 6.1.30 EE GA3. The data in AssetTag table still exists after the staged group was deleted. Failed on: Tomcat 7.0.40 + MySQL 5.5.21 Portal 6.1.x.EE GIT ID: 91e70a8331f537382702d5dd978106ea1392b9bc. The data in AssetTag table still exists after the staged group was deleted.
          Hide
          Sharry Shi added a comment -

          FAILED Manual Testing following the steps in the description.

          Failed on:
          Tomcat 7.0.40 + MySQL 5.5.21 Portal 6.1.x.EE GIT ID: 6b40d17081294063b97c21a788e1ad06c6a2889d.

          The data in AssetTag table still exists after the staged group was deleted.

          Show
          Sharry Shi added a comment - FAILED Manual Testing following the steps in the description. Failed on: Tomcat 7.0.40 + MySQL 5.5.21 Portal 6.1.x.EE GIT ID: 6b40d17081294063b97c21a788e1ad06c6a2889d. The data in AssetTag table still exists after the staged group was deleted.
          Hide
          Sharry Shi added a comment -

          PASSED Manual Testing following the steps in the description.

          Fixed on:
          Tomcat 7.0.40 + MySQL 5.5.21 Portal 6.1.x.EE GIT ID: 6b40d17081294063b97c21a788e1ad06c6a2889d.

          The data in AssetTag table deleted after the staged group was deleted.

          Show
          Sharry Shi added a comment - PASSED Manual Testing following the steps in the description. Fixed on: Tomcat 7.0.40 + MySQL 5.5.21 Portal 6.1.x.EE GIT ID: 6b40d17081294063b97c21a788e1ad06c6a2889d. The data in AssetTag table deleted after the staged group was deleted.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Days since last comment:
                1 year, 29 weeks, 1 day ago

                Development

                  Structure Helper Panel