Details

    • Branch Version/s:
      6.1.x
    • Backported to Branch:
      Committed
    • Liferay Contributor's Agreement:
      Accept
    • Similar Issues:
      Show 4 results 

      Description

      My MarketPlace plugin would spawn java to compile the Vaadin widgetset.

      In unix/linux/macos this would be "java" as defined by $JAVA_HOME/bin/java, $JRE_HOME/bin/java, or just 'java' found in the system path.

      In windows this would be "java.exe" as defined by %JAVA_HOME%\bin\java.exe, %JRE_HOME%\bin\java.exe, or just 'java.exe' found in the system path.

      Security manager references in liferay-plugin-package.properties should allow me to indicate I am executing 'java', but not force me to indicate full path (as each end system may have different version, different path, etc.).

      A more generic use case is that the plugin depends on installed software on the system, available as a simple command but uses the system's facilities to launch (i.e. needs to run the 'diff' command to create a patch file, but 'diff'/'diff.exe' could be anywhere on the system and plugin has no knowledge of where it is actually running from).

        Activity

        Hide
        Dave Nebinger added a comment -
        Show
        Dave Nebinger added a comment - The forum thread re: this bug is http://www.liferay.com/community/forums/-/message_boards/message/24026094
        Hide
        Dave Nebinger added a comment -

        The title of this bug should be "Allow $

        {java.home}

        and $

        {env:ENV_VAR}

        as replacements in PACL," as discussed in the forum thread.

        The addition will allow marketplace developers to define read/write/execute rules that do not require knowing the target system filesystem layout.

        Show
        Dave Nebinger added a comment - The title of this bug should be "Allow $ {java.home} and $ {env:ENV_VAR} as replacements in PACL," as discussed in the forum thread. The addition will allow marketplace developers to define read/write/execute rules that do not require knowing the target system filesystem layout.
        Hide
        Dave Nebinger added a comment -

        Just submitted a pull request that implements the solution. https://github.com/liferay/liferay-portal/pull/355

        Show
        Dave Nebinger added a comment - Just submitted a pull request that implements the solution. https://github.com/liferay/liferay-portal/pull/355
        Hide
        Dave Nebinger added a comment -

        Great that this is selected for development! My pull request is still out there as a resolution...

        Show
        Dave Nebinger added a comment - Great that this is selected for development! My pull request is still out there as a resolution...
        Hide
        Raymond Auge added a comment -

        Awaiting the contributor's agreement for https://github.com/rotty3000/liferay-portal/pull/216.

        Show
        Raymond Auge added a comment - Awaiting the contributor's agreement for https://github.com/rotty3000/liferay-portal/pull/216 .
        Hide
        Raymond Auge added a comment -

        Further tests were ported to liferay-plugins/portlet/test-pacl-portlet via https://github.com/brianchandotcom/liferay-plugins/pull/1618

        Show
        Raymond Auge added a comment - Further tests were ported to liferay-plugins/portlet/test-pacl-portlet via https://github.com/brianchandotcom/liferay-plugins/pull/1618
        Hide
        Justin Choi added a comment -

        PASSED Manual Testing using the following steps:

        1. Activate java security in the setenv.bat|sh file.
        2. In the portal-ext.properties, set
           portal.security.manager.strategy=liferay
        3. Start Liferay.
        4. Deploy the test-pacl-portlet and its dependencies: chat, flash, and sample-server builder
        5. Add the test-pacl-portlet to the page.
        6. Shut down the app server.
        7. Verify there are no memory leaks from the PACL portlet.
        8. Verify there are no portal webapps leaks.

        Fixed on:
        Tomcat 7.0.40 + MySQL 5. Portal 6.1.x EE GIT ID: a681207220790d8d984a8e0db1111ed1b9b43660. Plugins 6.1.x EE GIT ID: 8f8e3bd2859e0098f32deda0b02f77280a9251ec.
        Tomcat 7.0.42 + MySQL 5. Portal 6.2.x EE GIT ID: f7a096d9d1a130df20b671cd2af9a38c160475a7. Plugins 6.2.x EE GIT ID: d24b211c546b20f8cd4c0083882a9e24ce96a1cd.

        • Changes to the liferay.plugin.package.properties and the /docroot/view.jsp files make detecting JAVA_HOME neutral as to Windows or Unix/Linux environments.
        Show
        Justin Choi added a comment - PASSED Manual Testing using the following steps: Activate java security in the setenv.bat|sh file. In the portal-ext.properties, set portal.security.manager.strategy=liferay Start Liferay. Deploy the test-pacl-portlet and its dependencies: chat, flash, and sample-server builder Add the test-pacl-portlet to the page. Shut down the app server. Verify there are no memory leaks from the PACL portlet. Verify there are no portal webapps leaks. Fixed on: Tomcat 7.0.40 + MySQL 5. Portal 6.1.x EE GIT ID: a681207220790d8d984a8e0db1111ed1b9b43660. Plugins 6.1.x EE GIT ID: 8f8e3bd2859e0098f32deda0b02f77280a9251ec. Tomcat 7.0.42 + MySQL 5. Portal 6.2.x EE GIT ID: f7a096d9d1a130df20b671cd2af9a38c160475a7. Plugins 6.2.x EE GIT ID: d24b211c546b20f8cd4c0083882a9e24ce96a1cd. Changes to the liferay.plugin.package.properties and the /docroot/view.jsp files make detecting JAVA_HOME neutral as to Windows or Unix/Linux environments.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Days since last comment:
              1 year, 23 weeks, 1 day ago

              Development

                Structure Helper Panel