Staging queries are made for every layout due to LayoutLister.getLayoutView()

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 6.1.1 CE GA2, 6.1.20 EE GA2
• Fix Version/s: 6.1.2 CE GA3, 6.1.30 EE GA3, 6.2.0 CE M6
• Component/s: WCM, WCM > Site Administration > Staging
• Labels:
  • QA-C
  • staging
• Branch Version/s:
  6.1.x
• Backported to Branch:
  Committed
• Fix Priority: 4
• Similar Issues: Show 5 results ; ;

  LPS-1524	Every war is deployed twice.
  LPS-25556	Remote publishing is broken with upgraded 5.1 database due to Layout UUID differences
  LPS-18808	Staging problem causes "possible nonthreadsafe access to session" hibernate error
  LPS-30151	VerifyPermission is very slow when there are many layouts
  LPS-5024	Layout - add query string in friendlyURL

The method: LayoutLister.getLayoutView()
seems to be slowing the "manage pages" down because it has a recursive method called _createList(long parentLayoutId, int parentId, int depth) which iterates through each layout to get the child layouts of each set. For example, if you have a number such as 10,000 pages, then it will call _createList_createList() 10,000 times and you will have 10,000 queries in the database. Based on the testing, we believe this is what's causing the slowness.

[Brian Wulbern]

PASSED Manual Testing using the following steps:

1. Set the Log Levels (Control Panel > Server Administration > Log Levels)
   • Update Category: com.liferay.portal.lar --> DEBUG
   • Add Category: com.liferay.portal.service.persistence.LayoutRevisionPersistenceImpl --> DEBUG
2. Create a Site with 1000 pages (using a script in a browser console, or in firebug -
   AUI().Get.script('http://git.io/sGKk5w'); works, just follow the prompts--thanks to Marc Lundgren for that tool)
   • Wait a minute or two for the command to finish
3. Navigate to Site Settings for the created Site > Staging
4. Enable Local Live Staging
   • Flag Public Page versioning
5. Click Save
6. Observe the output in console

Reproduced on:
Tomcat 7 + MySQL 5. Portal 6.2.x GIT ID: 08b3a3090df012a50efc994c564239cc4a59c454.

Fixed on:
Tomcat 7 + MySQL 5. Portal EE 6.1.x GIT ID: a75a13983d07d99d066f6cf20ef853bd1766af95.
Tomcat 7 + MySQL 5. Portal 6.2.x GIT ID: 1725e10b8a2f6d0bc75f01158456ffb9e10b47da.

With the GIT ID the issue was reproduced on, the conversion to versioned Staging takes more than 120 seconds with 1000 pages. On the fixed versions for 6.1.x and 6.2.x, it takes 12 seconds and 24 seconds, respectively. This difference is more noticeable with increased numbers of pages.