Details

    • Branch Version/s:
      6.1.x
    • Backported to Branch:
      Committed
    • Story Points:
      6
    • Similar Issues:
      Show 2 results 

      Description

      Steps to reproduce:
      1) Install kaleo
      2) Configure mail server for sending email notifications and set your email address
      3) Add kaleo forms portlet to page
      4) Switch to "Process" Tab . Click on "Add"
      5) Enter Name, select an Entry Definition, create and select an Initial Form
      6) Select Workflow > Edit the Single Approver
      7) Click on the Review node
      8) Double click on the Notifications field under the Settings tab to edit it
      9) Change the Template Language from Text to Freemarker for notification with execution type "On Assignment"
      10) Add ${taskComments} anywhere in the template
      11) Click Save, then Publish. Select this newly created version of the Workflow Definition
      12) Click Save, go to Summary tab of portlet, Submit New > select process you created
      13) Assign it to the user with the email address and Save
      14) See errors in console

      1. ErrorLog.txt
        9 kB
        Shitian "Shelton" Zhang

        Activity

        Show
        Bryan Engler added a comment - plugins pr https://github.com/matthewkong/liferay-plugins/pull/49
        Hide
        Shitian "Shelton" Zhang added a comment -

        FAILED Manual Testing following the steps in the description.

        Reproduced on:
        Tomcat 7.0 + MySQL 5. Portal 6.1.20 EE GA2.

        Errors appeared in console after clicking save.

        Fixed on:
        Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: 182962b3930bebb2346b757ff84c2afad9aa502a.
        Plugins 6.1.x EE GIT ID: a622f4d059a65e8dbf4b23e62da908f9d4ba09ee.

        It saved properly and no error shows in console.

        Failed on:
        Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 6d480cbf684ebb181177ee0dda6311cb6e42d07a.
        Plugins 6.2.x EE GIT ID: 9a89207f92793b23ea8ccede33402e43fbe231dd.

        Errors appeared in console after clicking save.

        Show
        Shitian "Shelton" Zhang added a comment - FAILED Manual Testing following the steps in the description. Reproduced on: Tomcat 7.0 + MySQL 5. Portal 6.1.20 EE GA2. Errors appeared in console after clicking save. Fixed on: Tomcat 7.0 + MySQL 5. Portal 6.1.x EE GIT ID: 182962b3930bebb2346b757ff84c2afad9aa502a. Plugins 6.1.x EE GIT ID: a622f4d059a65e8dbf4b23e62da908f9d4ba09ee. It saved properly and no error shows in console. Failed on: Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 6d480cbf684ebb181177ee0dda6311cb6e42d07a. Plugins 6.2.x EE GIT ID: 9a89207f92793b23ea8ccede33402e43fbe231dd. Errors appeared in console after clicking save.
        Hide
        Bryan Engler added a comment -

        it looks like the name of the serviceContext attributes has changed in 6.2
        now instead of "comments"->"this is the comment"
        it shows something like "comments_INSTANCE_nqdl"->"this is the comment"
        so using serviceContext.getAttribute("comments") like we did for 6.1 is not going to work

        Show
        Bryan Engler added a comment - it looks like the name of the serviceContext attributes has changed in 6.2 now instead of "comments"->"this is the comment" it shows something like "comments_INSTANCE_nqdl"->"this is the comment" so using serviceContext.getAttribute("comments") like we did for 6.1 is not going to work
        Hide
        Norbert Kocsis added a comment -

        Hi Bryan,

        Your fix generates an exception when a new web content is created. When the new workflow starts the task comments is null and when FreemarkerContext is populated it throws a NullPointerException because ConcurrentHashMap doesn't accept null values (com.liferay.portal.workflow.kaleo.runtime.notification.FreeMarkerNotificationMessageGenerator line:90).

        Br,
        Norbert

        Show
        Norbert Kocsis added a comment - Hi Bryan, Your fix generates an exception when a new web content is created. When the new workflow starts the task comments is null and when FreemarkerContext is populated it throws a NullPointerException because ConcurrentHashMap doesn't accept null values (com.liferay.portal.workflow.kaleo.runtime.notification.FreeMarkerNotificationMessageGenerator line:90). Br, Norbert
        Hide
        Bryan Engler added a comment -

        pull request is for 61x only

        Show
        Bryan Engler added a comment - pull request is for 61x only
        Hide
        Shitian "Shelton" Zhang added a comment -

        PASSED Manual Testing following the steps in the description.

        Fixed on:
        Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: bc9eac95980e94c7263ca84b3243b273f018469f.
        Plugins 6.2.x EE GIT ID: bfb095d2c0fac0b1ac8b8981fbfaacc9b896d4a4.

        It saved properly and no error shows in console.

        Show
        Shitian "Shelton" Zhang added a comment - PASSED Manual Testing following the steps in the description. Fixed on: Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: bc9eac95980e94c7263ca84b3243b273f018469f. Plugins 6.2.x EE GIT ID: bfb095d2c0fac0b1ac8b8981fbfaacc9b896d4a4. It saved properly and no error shows in console.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Days since last comment:
              1 year, 49 weeks ago

              Development

                Structure Helper Panel