Details

    • Story Points:
      6
    • Similar Issues:
      Show 5 results 

      Description

      Kaleo ignores some Users when sending out notifications or providing the list of potential reviewers. This applies to users who only inherit the Reviewer Role from a User Group. Although this issue has been fixed for Site Content Reviewer role (LPS-37466 and LPS-38447), the problem still persists when Regular Roles are used (e.g. the Portal Content Reviewer role).

      Reproduction steps:

      1. Start the Portal with Kaleo deployed, and set up an outgoing email server
      2. Create a User Group
      3. Assign this User Group to the default Liferay site
      4. Assign the Portal Content Reviewer role to your User Group
      5. Create a user and assign her to the above User Group
      6. Assign yourself to the User Group, too
      7. Set the Single Approver workflow for Web Contents
      8. Create a Web Content, submit it for review
      9. Check the My Workflow Tasks tab, and try to assign someone else
      10. Result: you won't see the "Assign to..." option, furthermore you didn't get an email about the Web Content submitting
      1. attachment.JPG
        195 kB
      2. attachment1.gif
        4.93 MB
      3. attachment2.JPG
        63 kB
      4. attachment3.JPG
        63 kB

        Issue Links

          Activity

          Hide
          József Illés (Inactive) added a comment -

          Hi Eduardo,

          Could you please take a look at these 2 pull requests?

          Thanks,
          Jozsef

          Show
          József Illés (Inactive) added a comment - Hi Eduardo, Could you please take a look at these 2 pull requests? Thanks, Jozsef
          Hide
          Serena Song (Inactive) added a comment -

          PASSED Manual Testing following the steps in the description.

          Reproduced on:
          Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 6982b598ad96c5ac119512beb1b7279df8237d87.
          Plugins master GIT ID: 68e0207c21b57c770f6ca823e29b2040affd234a.

          Kaleo's Regular Roles not inherited from User Groups.

          Fixed on:
          Tomcat 7.0 + MySQL 5. Portal master GIT ID: 03878542de3471733a95380d3cce4242252cd0a7.
          Plugins master GIT ID: 321e2e065dcd2ad75c1eb06970efa798a0564f25.

          You can see "Assign to" option and receive email about the Web Content submitting successfully.

          Show
          Serena Song (Inactive) added a comment - PASSED Manual Testing following the steps in the description. Reproduced on: Tomcat 7.0 + MySQL 5. Portal 6.2.x GIT ID: 6982b598ad96c5ac119512beb1b7279df8237d87. Plugins master GIT ID: 68e0207c21b57c770f6ca823e29b2040affd234a. Kaleo's Regular Roles not inherited from User Groups. Fixed on: Tomcat 7.0 + MySQL 5. Portal master GIT ID: 03878542de3471733a95380d3cce4242252cd0a7. Plugins master GIT ID: 321e2e065dcd2ad75c1eb06970efa798a0564f25. You can see "Assign to" option and receive email about the Web Content submitting successfully.
          Hide
          Benson Lau added a comment - - edited

          Hi Serena,

          I am still able to reproduce this issue.

          Email notifications are still not being received when a regular role is inherited by the user group (in my case it is the portal content review role). I am able to see the 'assign to' option, but only the omni-admin is receiving the notification email.

          Here are some modified and simplified steps:

          1) Create user and user group
          2) Edit portal content reviewer role to include the user group created above
          3) Edit user to make him a member of the user group created above
          -make sure this user does not already have the regular role of portal content reviewer role
          4) Create web content and submit for publication
          5) Omni admin user will receive email notification of the new workflow waiting approval but the user created in step 1 that inherits the portal content reviewer role does not receive an email notification.

          Show
          Benson Lau added a comment - - edited Hi Serena, I am still able to reproduce this issue. Email notifications are still not being received when a regular role is inherited by the user group (in my case it is the portal content review role). I am able to see the 'assign to' option, but only the omni-admin is receiving the notification email. Here are some modified and simplified steps: 1) Create user and user group 2) Edit portal content reviewer role to include the user group created above 3) Edit user to make him a member of the user group created above -make sure this user does not already have the regular role of portal content reviewer role 4) Create web content and submit for publication 5) Omni admin user will receive email notification of the new workflow waiting approval but the user created in step 1 that inherits the portal content reviewer role does not receive an email notification.
          Hide
          Serena Song (Inactive) added a comment - - edited

          Hi Benson,

          I have retested it on master GIT ID: 83e25a9ac395497f47fd5a1e06a10cfe928725c3 and I can receive the email for the newly created user. After click submit for publication, the new user "serena"(inherits the portal content reviewer role) will receive a email: "Test Test sent you a Web Content Article for review in the workflow". I upload 3 attachments to reflect the result. I am not sure the problem is network reason or not make us have different results.

          Show
          Serena Song (Inactive) added a comment - - edited Hi Benson, I have retested it on master GIT ID: 83e25a9ac395497f47fd5a1e06a10cfe928725c3 and I can receive the email for the newly created user. After click submit for publication, the new user "serena"(inherits the portal content reviewer role) will receive a email: "Test Test sent you a Web Content Article for review in the workflow". I upload 3 attachments to reflect the result. I am not sure the problem is network reason or not make us have different results.
          Hide
          Benson Lau added a comment -

          Thank you for providing that information Serena. I was actually missing a commit that was needed to resolve the issue. After discussing this issue on LPP-7848, i found out I needed to have hotfix-1994-6120 installed. I have this issue resolved on my end as well, so feel free to close out this lps! Thanks again for your help.

          Show
          Benson Lau added a comment - Thank you for providing that information Serena. I was actually missing a commit that was needed to resolve the issue. After discussing this issue on LPP-7848, i found out I needed to have hotfix-1994-6120 installed. I have this issue resolved on my end as well, so feel free to close out this lps! Thanks again for your help.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Days since last comment:
                1 year, 44 weeks, 1 day ago

                Development

                  Structure Helper Panel