Details
-
Story
-
Status: Closed
-
Minor
-
Resolution: Completed
-
6.1.20 EE GA2
-
None
-
Application Server: Websphere 8
Description
testing with Websphere8 and Weblogic10, the GZip Filter is not working.
This is due to com.liferay.portal.servlet.filters.gzip.GZipFilter class, in row 41 there is this code:
// The compression filter will work on JBoss, Jetty, JOnAS, OC4J, and // Tomcat, but may break on other servers if (super.isFilterEnabled()) { if (ServerDetector.isJBoss() || ServerDetector.isJetty() || ServerDetector.isJOnAS() || ServerDetector.isOC4J() || ServerDetector.isTomcat()) { _filterEnabled = true; } else { _filterEnabled = false; } }
I was searching for explanation, unfortunately I didn't find any, only these JIRA tickets: LPS-24548, LPS-24547, LPS-7599, where somebody confirmed that by adding the following function, the gzipfilter works under websphere. ServerDetector.isWebSphere()
Are there any issues (explanation) that prevent this function to be added to the code?
Please review these rules for gzipping.