PUBLIC - Liferay Portal Community Edition
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-42530

Notifications related to deleted items cause errors and exceptions

    Details

    • Branch Version/s:
      6.2.x
    • Backported to Branch:
      Committed
    • Epic/Theme:
    • Fix Priority:
      5
    • Similar Issues:
      Show 3 results 

      Description

      Here are the steps to reproduce:

      1. Add a General Announcement
      2. Refresh the page and view the notification WITHOUT clicking on it
      3. Delete the General Announcement
      4. Refresh the page.

      Expected result:

      The notification should be removed

      Actual result:

      The notification count remains at 1. Clicking on the notification will result in exceptions and an error. Another refresh will clear the error.

      1. Announcement exceptions.txt
        240 kB
        Ken Duenwald
      2. NullPointerException.txt
        108 kB
        Ken Duenwald

        Activity

        Hide
        Ken Duenwald added a comment -

        Blocked from testing by compile error in 6.2.x CE

        Show
        Ken Duenwald added a comment - Blocked from testing by compile error in 6.2.x CE
        Hide
        Ken Duenwald added a comment -

        FAILED Manual Testing following the steps in the description.

        Fixed on:
        Tomcat 7.0.42 + MySQL 5. Portal 6.2.0 CE GA1.
        Plugins 6.2.x CE GIT ID: 5123c0002b569b9f4145f5ec8ca30601c3ee9592.

        There is no longer a visible error, but a NullPointerException still displays at the end of the test steps

        Show
        Ken Duenwald added a comment - FAILED Manual Testing following the steps in the description. Fixed on: Tomcat 7.0.42 + MySQL 5. Portal 6.2.0 CE GA1. Plugins 6.2.x CE GIT ID: 5123c0002b569b9f4145f5ec8ca30601c3ee9592. There is no longer a visible error, but a NullPointerException still displays at the end of the test steps
        Hide
        mandy.zia added a comment - - edited

        PASSED Manual Testing following the steps in the description.

        To test without deploying all SO plugins, build and deploy the following plugins before following the steps:
        notifications-portlet, marketplace-portlet, and so-announcements-portlet.

        Actual result: After refreshing the page, the notification count goes down (expected), but the console will still shows the "NullPointerException.txt" console output. This is expected.

        Please note that the "Unable to interpret notification" NPE is intentional and like Jon Lee's comment above, is used as a way to log and notify users that an announcement was deleted. From a conversation with Jon, what is happening is that a notification is sent out once the announcement was created. But after you delete the announcement, the notifications portlet doesn't know that the announcement is gone so it tries to display the announcement. At which point, it realizes that the announcement is gone and thus throw the error log and deletes the notification. If you refresh the page after that, you will notice that there will be no more errors.

        PASSED on:
        Tomcat 7 + MySQL 5. Portal Master Git ID: 1b1774f1ad73b91973ffeffc67170cb3d2089a63.
        Plugins Master Git ID: 8c4f38b7360d726a4e724f06030a5333b8d34d12.
        Tomcat 7 + MySQL 5. Portal 6.2.x CE Git ID: 9cda2081df4e0b2d2f951b8181952736be17e83b.
        Plugins 6.2.x CE Git ID: c54b63aa134f38331eb98d539bbae961a522acff.

        Show
        mandy.zia added a comment - - edited PASSED Manual Testing following the steps in the description. To test without deploying all SO plugins, build and deploy the following plugins before following the steps: notifications-portlet, marketplace-portlet, and so-announcements-portlet. Actual result: After refreshing the page, the notification count goes down (expected), but the console will still shows the "NullPointerException.txt" console output. This is expected. Please note that the "Unable to interpret notification" NPE is intentional and like Jon Lee's comment above, is used as a way to log and notify users that an announcement was deleted. From a conversation with Jon, what is happening is that a notification is sent out once the announcement was created. But after you delete the announcement, the notifications portlet doesn't know that the announcement is gone so it tries to display the announcement. At which point, it realizes that the announcement is gone and thus throw the error log and deletes the notification. If you refresh the page after that, you will notice that there will be no more errors. PASSED on: Tomcat 7 + MySQL 5. Portal Master Git ID: 1b1774f1ad73b91973ffeffc67170cb3d2089a63. Plugins Master Git ID: 8c4f38b7360d726a4e724f06030a5333b8d34d12. Tomcat 7 + MySQL 5. Portal 6.2.x CE Git ID: 9cda2081df4e0b2d2f951b8181952736be17e83b. Plugins 6.2.x CE Git ID: c54b63aa134f38331eb98d539bbae961a522acff.
        Hide
        mandy.zia added a comment - - edited

        PASSED Manual Testing following the steps in the comment. Can also be tested with sending a private message and deleting it before viewing the notification.

        There is no longer any NPE in the console, and the notification count will decrease on its own if you wait a little or by refreshing the page.

        Fixed on:
        Tomcat 7 + MySQL 5. Portal 6.2.10 EE GA1.
        Plugins 6.2.X EE Git ID: 98547a9f3cb26090f1a67a14eb423f3645f8ab16.

        Show
        mandy.zia added a comment - - edited PASSED Manual Testing following the steps in the comment. Can also be tested with sending a private message and deleting it before viewing the notification. There is no longer any NPE in the console, and the notification count will decrease on its own if you wait a little or by refreshing the page. Fixed on: Tomcat 7 + MySQL 5. Portal 6.2.10 EE GA1. Plugins 6.2.X EE Git ID: 98547a9f3cb26090f1a67a14eb423f3645f8ab16.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Days since last comment:
              1 year, 26 weeks, 5 days ago

              Development

                Structure Helper Panel