Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-43671

SASS build errors go unnoticed because errors are swallowed in SassToCssBuilder

    Details

    • Type: Bug
    • Status: Closed
    • Resolution: Fixed
    • Affects Version/s: 6.1.20 EE GA2, 6.1.30 EE GA3, 6.1.X EE, 6.2.10 EE GA1, 6.2.X EE, 7.0.0 M3
    • Environment:

      Description

      SASS build errors go unnoticed because errors are swallowed in SassToCssBuilder

      When a theme author has written invalid SASS, it isn't obvious there's been an error.

      Steps to Reproduce:

      1. Go to a theme (themes\zoe-healthcare-theme)
      2. Edit SASS file and introduce Erring SASS Sample (themes\zoe-healthcare-theme\docroot_diffs\css\custom.css)
      3. Build WAR $ ant clean war (use clean each time to ensure SASS is parsed)

      Expected Results
      BUILD FAILED

      Actual Results
      BUILD SUCCESSFUL (with an easy to miss stack trace)

      Erring SASS Sample

      ...
      .aui {
      	#breadcrumbs, #heading .page-title, #navigation .child-menu, #navigation h1, #skip-to-content {
      		clip: rect(0 0 0 0);
      		height: 0;
      		margin: 0;
      		padding: 0;
      		position: absolute;
      	<} /*Bad syntax*/
      ...
      

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Days since last comment:
                  5 years, 51 weeks, 2 days ago

                  Packages

                  Version Package
                  6.2.2 CE GA3
                  6.2.4 CE GA5
                  6.2.X EE
                  7.0.0 M1