Details

    • Branch Version/s:
      6.2.x
    • Backported to Branch:
      Committed
    • Story Points:
      8
    • Similar Issues:
      Show 5 results 
    1. fix.png
      15 kB
    2. reproduced.png
      13 kB

      Activity

      Hide
      Brian Chan added a comment -

      I rolled back all of LPS-44440. We should never be calling getPortalServerPort like that. That's the internal one. For example, if we are using Apache and it's listening on port 80 but Tomcat is also listening on port 8080, then getPortalServerPort will return 8080 and NOT 80. And often times, that port is blocked behind the FW.

      Please resend. Thx.

      Show
      Brian Chan added a comment - I rolled back all of LPS-44440 . We should never be calling getPortalServerPort like that. That's the internal one. For example, if we are using Apache and it's listening on port 80 but Tomcat is also listening on port 8080, then getPortalServerPort will return 8080 and NOT 80. And often times, that port is blocked behind the FW. Please resend. Thx.
      Hide
      Eduardo Lundgren added a comment -

      Brian,

      PortalUtil.getPortalServerPort(boolean) already handle the case of front end servers.

      In 6.2.x it has getPortalPort(), it is the same as getPortalServerPort() in master.
      This is exact the same as Servlet API's server/local address/port. We are just recording and exposing them.

      I re-send the same code, make sure to update the call to getPortalPort() when backport.

      https://github.com/brianchandotcom/liferay-plugins/pull/2727

      Show
      Eduardo Lundgren added a comment - Brian, PortalUtil.getPortalServerPort(boolean) already handle the case of front end servers. In 6.2.x it has getPortalPort(), it is the same as getPortalServerPort() in master. This is exact the same as Servlet API's server/local address/port. We are just recording and exposing them. I re-send the same code, make sure to update the call to getPortalPort() when backport. https://github.com/brianchandotcom/liferay-plugins/pull/2727
      Hide
      Hong Zhao added a comment -

      PASSED Manual Testing using the following steps.

      1. Start portal, Admin > Control Panel > Configuration > Server Administration, configure the mail settings .
      2. Eidt the user (Test), set a valid email address.
      3. Deploy calendar portlet, add an event.
      4. Sent invitations to Test user, check the Test user's mail box.
      5. Update the event, check the Test user's mail box again.

      Reproduced on:
      Tomcat 7.0.42 + MySQL 5.5.29. Portal ee-6.2.x EE GIT ID: ac518fee5991ffab8240aea367048466218ae9d6.
      Plugins ee-6.2.x EE GIT ID: 0d9752f60e5ae18b6281b5233744ca33b13cc611.

      Calendar notification messages doesn't always generate links to update the event (reproduced.png).

      Fixed on:
      Tomcat 7.0.42 + MySQL 5.5.29. Portal master GIT ID: 7d7da0792f72b0ca0c254282e454d7c6354c50a9.
      Plugins master GIT ID: 5f59e83d1b653a0c12218ebcf9da938219d0f993.
      Tomcat 7.0.42 + MySQL 5.5.29. Portal ee-6.2.x EE GIT ID: ac518fee5991ffab8240aea367048466218ae9d6.
      Plugins ee-6.2.x EE GIT ID: d9df59a91c0b94eae341456640e6f22d545fb9af.

      Calendar notification messages could generate links to update the event (fix.png).

      Show
      Hong Zhao added a comment - PASSED Manual Testing using the following steps. 1. Start portal, Admin > Control Panel > Configuration > Server Administration, configure the mail settings . 2. Eidt the user (Test), set a valid email address. 3. Deploy calendar portlet, add an event. 4. Sent invitations to Test user, check the Test user's mail box. 5. Update the event, check the Test user's mail box again. Reproduced on: Tomcat 7.0.42 + MySQL 5.5.29. Portal ee-6.2.x EE GIT ID: ac518fee5991ffab8240aea367048466218ae9d6. Plugins ee-6.2.x EE GIT ID: 0d9752f60e5ae18b6281b5233744ca33b13cc611. Calendar notification messages doesn't always generate links to update the event (reproduced.png). Fixed on: Tomcat 7.0.42 + MySQL 5.5.29. Portal master GIT ID: 7d7da0792f72b0ca0c254282e454d7c6354c50a9. Plugins master GIT ID: 5f59e83d1b653a0c12218ebcf9da938219d0f993. Tomcat 7.0.42 + MySQL 5.5.29. Portal ee-6.2.x EE GIT ID: ac518fee5991ffab8240aea367048466218ae9d6. Plugins ee-6.2.x EE GIT ID: d9df59a91c0b94eae341456640e6f22d545fb9af. Calendar notification messages could generate links to update the event (fix.png).

        People

        • Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:
            Days since last comment:
            1 year, 23 weeks, 3 days ago

            Development

              Subcomponents

                Structure Helper Panel