Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-44965

VerifyOracle should reduce columns in 6.1.20 and above if you come from 5.2.9 or from 6.0.5 to 6.1.10

    Details

    • Branch Version/s:
      7.0.x, 6.2.x
    • Backported to Branch:
      Committed
    • Story Points:
      1.75
    • Fix Priority:
      4
    • Databases:
      Oracle Database 10.1, Oracle Database 10.2, Oracle Database 11.1, Oracle Database 11.2

      Description

      Since 6.1.20 the size of database columns in Oracle is the same than for the rest of the databases. From 6.0.5 to 6.1.10 and in 5.2.9 the column sizes were 4 times greater so the method verifyOracle alters the columns to reduce them.

      But we have the following check in that method (6.2.10):

      if (isBetweenBuildNumbers(
      		buildNumber, ReleaseInfo.RELEASE_5_2_9_BUILD_NUMBER,
      		ReleaseInfo.RELEASE_6_0_0_BUILD_NUMBER) ||
      	isBetweenBuildNumbers(
      		buildNumber, ReleaseInfo.RELEASE_6_0_5_BUILD_NUMBER,
      		ReleaseInfo.RELEASE_6_1_20_BUILD_NUMBER)) {
      
      	// LPS-33903
      
      	if (!ArrayUtil.contains(
      			_ORIGINAL_DATA_LENGTH_VALUES, dataLength)) {
      
      		dataLength = dataLength / 4;
      	}
      }
      

      And it's not correct because if you comes, for example, from 6.1.10 to 6.2.10/6.1.20 the columns should be reduced and they currently not.

      The attached exception is displayed in some cases after modifying the columns without reducing them (VerifyException: java.sql.SQLException: ORA-01404: ALTER COLUMN will make an index too large_)

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Days since last comment:
                  1 year, 41 weeks, 1 day ago

                  Zendesk Support