Details

    • Type: Technical Task Technical Task
    • Status: Closed
    • Resolution: Fixed
    • Affects Version/s: 7.0.0 M3
    • Fix Version/s: 6.2.X EE, 7.0.0 M1
    • Component/s: Calendar
    • Labels:
      None
    • Branch Version/s:
      6.2.x
    • Backported to Branch:
      Committed
    • Similar Issues:
      Show 5 results 

      Description

      Currently, in the Liferay.CalendarUtil.getEvents() method, the failure callback is called from an anonymous function enclosing it:

      A.io.request(
          calendarBookingsURL,
          {
              dataType: 'json',
              on: {
                  failure: function() {
                      failure(this.get('responseData'));
                  },
                  success: function() {
                      success(this.get('responseData'));
                  }
              }
          }
      );
      

      This is causing LPS-45223 because the failure callback is not passed to Liferay.CalendarUtil.getEvents() in edit_calendar_booking.jsp, resulting in a call to undefined.

      If we pass failure directly to A.io.request(), however (as it is done in Liferay.CalendarUtil.getEvent() and Liferay.CalendarUtil.invokeService()), the A.io.request() will take care of not calling an undefined value. This way, we should call the failure callback the same way it is called in getEvent() and invokeService().

        Activity

        Hide
        Marcellus Tavares added a comment -

        Just started reviewing :)

        Sent from GH.

        Show
        Marcellus Tavares added a comment - Just started reviewing :) Sent from GH .

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Days since last comment:
              1 year, 4 weeks, 2 days ago

              Development

                Structure Helper Panel