Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-45669

"dateParam" attribute from liferay-ui:input-time should be mandatory or have some default value

    Details

      Description

      For resolving LPS-39351, a new dateParam attribute was added to liferay-ui:input-time, similar to the ones created to resolve LPS-38402. However, the attributes from LPS-38402 (hourParam, minuteParam, amPmParam) are mandatory, while dateParam is optional. This results in an hidden input whose name and id are null.

      Steps to reproduce

      1. Create a portlet with a JSP file that creates a liferay-ui:input-time instance, as the one below:
        <liferay-ui:input-time name="test"
            hourParam="hour" minuteParam="minute" amPmParam="amPm" />
        
      2. Deploy the previous portlet. Add it to a page.
      3. Inspect the hidden inputs around the text input of the input-time.

      Expected results

      • All hidden inputs would have meaningful names.

      Actual results

      • One of the inputs is named null.

      The result is reproduced in the GIF animation below:

        Attachments

        1. 45669_master_bug.png
          45669_master_bug.png
          30 kB
        2. 45669_master_fix.png
          45669_master_fix.png
          25 kB
        3. fixed.png
          fixed.png
          34 kB
        4. LPS-45669.gif
          LPS-45669.gif
          4.82 MB

          Issue Links

            Activity

              People

              Assignee:
              hong.zhao Hong Zhao (Inactive)
              Reporter:
              adam.brandizzi Adam Brandizzi
              Participants of an Issue:
              Recent user:
              Esther Sanz
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Days since last comment:
                6 years, 27 weeks, 3 days ago

                  Packages

                  Version Package
                  6.2.2 CE GA3
                  6.2.X EE
                  7.0.0 M1