PUBLIC - Liferay Portal Community Edition
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-46280

Adding file with duplicate name to Sharepoint repository causes DM "temporarily unavailable" message

    Details

    • Branch Version/s:
      6.2.x
    • Backported to Branch:
      Committed
    • Fix Priority:
      3
    • Similar Issues:
      Show 5 results 

      Description

      Steps to Reproduce:

      1. Set up a sharepoint repository
      2. Start server and deploy Sharepoint hook
      3. Add a test page
      4. Add a Documents and Media portlet to test page
      5. Add the sharepoint repository
      6. Add folder to repo called “test”
      7. Add a basic document called “test”
      8. Assert portlet crash and console errors

      Expected result:
      User receives “Your request failed to complete.” and “Please enter a unique document name.” messages because they are trying to upload a file with a duplicate name.

      Actual result:
      User receives “Documents and Media is temporarily unavailable.” message and must reload the page before being able to access the portlet again. Console errors are also thrown.

      15:35:53,080 ERROR [http-bio-8080-exec-1][render_portlet_jsp:132] null
      com.liferay.sharepoint.connector.SharepointResultException: Unknown: A file with
       the name Documents/test already exists. It was last modified by (unknown) on 24
       Apr 2014 16:36:01 -0700.
              at com.liferay.sharepoint.connector.operation.AddOrUpdateFileOperation.execute(AddOrUpdateFileOperation.java:81)
              at com.liferay.sharepoint.connector.SharepointConnectionImpl.addFile(SharepointConnectionImpl.java:102)
              at com.liferay.sharepoint.repository.SharepointWSRepository.addExtRepositoryFileEntry(SharepointWSRepository.java:97)
              at com.liferay.repository.external.ExtRepositoryAdapter.addFileEntry(ExtRepositoryAdapter.java:99)
              at com.liferay.portal.kernel.bean.ClassLoaderBeanHandler.invoke(ClassLoaderBeanHandler.java:67)
              at com.liferay.portal.repository.proxy.BaseRepositoryProxyBean.addFileEntry(BaseRepositoryProxyBean.java:78)
              at com.liferay.portlet.documentlibrary.service.impl.DLAppServiceImpl.addFileEntry(DLAppServiceImpl.java:301)
              at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:115)
              at com.liferay.portal.spring.transaction.DefaultTransactionExecutor.execute(DefaultTransactionExecutor.java:62)
              at com.liferay.portal.spring.transaction.TransactionInterceptor.invoke(TransactionInterceptor.java:51)
              at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:111)
              at com.liferay.portal.spring.aop.ChainableMethodAdvice.invoke(ChainableMethodAdvice.java:56)
              at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:111)
              at com.liferay.portal.spring.aop.ChainableMethodAdvice.invoke(ChainableMethodAdvice.java:56)
              at com.liferay.portal.spring.aop.ServiceBeanMethodInvocation.proceed(ServiceBeanMethodInvocation.java:111)
              at com.liferay.portal.spring.aop.ServiceBeanAopProxy.invoke(ServiceBeanAopProxy.java:175)
              at com.liferay.portlet.documentlibrary.service.DLAppServiceUtil.addFileEntry(DLAppServiceUtil.java:196)
              at com.liferay.portlet.documentlibrary.action.EditFileEntryAction.updateFileEntry(EditFileEntryAction.java:1033)
              at com.liferay.portlet.documentlibrary.action.EditFileEntryAction.processAction(EditFileEntryAction.java:154)
              at com.liferay.portal.struts.PortletRequestProcessor.process(PortletRequestProcessor.java:166)
      

      This errors occurs on both master and ee-6.2.x on:

      Tomcat 7.0.42 + MySQL 5.5. Portal master GIT ID: bf74b0f332da3fc0693e6561f6c1274316117299.
      Tomcat 7.0.42 + MySQL 5.5. Portal ee-6.2.x GIT ID: 3e209edbec633b051896bebf000688dd43364bf4.

        Activity

        Hide
        Ivan Zaera added a comment -

        I've fixed this bug in ee-6.2.x, but it should be forward ported to master.

        Show
        Ivan Zaera added a comment - I've fixed this bug in ee-6.2.x, but it should be forward ported to master.
        Hide
        Victor Ware added a comment - - edited

        PASSED Manual Testing following the steps in the description.

        Fixed on:
        Tomcat 7.0.42 + MySQL 5.5 Portal ee-6.2.x GIT ID: 0cfbf763f19a26ed14f3b6f3f5c8ca343c4f95e9.
        Tomcat 7.0.42 + MySQL 5.5 Portal master GIT ID: d91cf625a42ad2d305165a8a2d580d29fa439aa1.

        User correctly receives “Your request failed to complete.” and “Please enter a unique document name.” messages when trying to add a document with a duplicate name. No console errors.

        Show
        Victor Ware added a comment - - edited PASSED Manual Testing following the steps in the description. Fixed on: Tomcat 7.0.42 + MySQL 5.5 Portal ee-6.2.x GIT ID: 0cfbf763f19a26ed14f3b6f3f5c8ca343c4f95e9. Tomcat 7.0.42 + MySQL 5.5 Portal master GIT ID: d91cf625a42ad2d305165a8a2d580d29fa439aa1. User correctly receives “Your request failed to complete.” and “Please enter a unique document name.” messages when trying to add a document with a duplicate name. No console errors.

          People

          • Assignee:
            Victor Ware
            Reporter:
            Victor Ware
            Recent user:
            Esther Sanz
            Participants of an Issue:
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Days since last comment:
              49 weeks, 1 day ago

              Development

                Structure Helper Panel