PUBLIC - Liferay Portal Community Edition
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-46637

Auto-saves on in-place editing in the Blogs Portlet sends email notifications to all blog subscribers for the unfinished edit

    Details

    • Epic/Theme:
    • Fix Priority:
      3
    • Similar Issues:
      Show 5 results 

      Description

      Issue: Auto-saves on in-place editing in the Blogs Portlet sends email notifications to all blog subscribers for the unfinished edit

      Steps to Reproduce:
      1. Navigate to Control Panel > Server Administration > Mail
      2. Set up SMTP Mail Server
      3. Navigate to Front Page of Default Site
      4. Add Blogs Portlet to page
      5. Select Configuration Cog > Configuration
      6. Verify that Email From address is same as address used for SMTP Server in Step 2. Select Save.
      7. Subscribe to Blogs Portlet as User by selecting the "Subscribe" button in the Portlet
      8. Create a new Blog Post. Name it "Test" and add some content
      9. Post the article
      10. On the Front Page of the Blog Portlet there should be a dotted box around the Blog Post. If you click in that text area, you are able to perform in-place edits.
      11. Start editing the Blog Post until a green box appears that notes that the content was "Auto-saved."
      12. Check your email.

      Expected Result: The Email notification is not sent until the user stops editing the Blog Content
      Actual Result: An email notification is sent when the Auto-save occurs, even if you are not done with in-place edits.

        Issue Links

          Activity

          Hide
          Joshua Gok added a comment -

          This is not a bug. It is intended behavior to send out email notifications after every autosave event.

          Show
          Joshua Gok added a comment - This is not a bug. It is intended behavior to send out email notifications after every autosave event.
          Hide
          Minhchau Dang added a comment -

          It turns out that this is a bug, based on feedback from PM for collaboration component.

          However, we are on the fence of which direction to take – whether we fix the subscriptions aspect to ignore inline edits (and/or not send notifications when no actual changes occur), or if we go the route of LPS-48701 where we would allow portal administrators to disable the inline editor.

          Also with LPS-46847 allowing us to centralize some of the inline edit handling, it may make sense to allow it to be configurable per portlet, similar to how WYSIWYG works with a key. However, this treads into new feature territory so we are unsure how well it fits into the product roadmap.

          Show
          Minhchau Dang added a comment - It turns out that this is a bug, based on feedback from PM for collaboration component. However, we are on the fence of which direction to take – whether we fix the subscriptions aspect to ignore inline edits (and/or not send notifications when no actual changes occur), or if we go the route of LPS-48701 where we would allow portal administrators to disable the inline editor. Also with LPS-46847 allowing us to centralize some of the inline edit handling, it may make sense to allow it to be configurable per portlet, similar to how WYSIWYG works with a key. However, this treads into new feature territory so we are unsure how well it fits into the product roadmap.
          Hide
          Sergio Gonzalez added a comment -

          Hey guys,

          As Minchau already commented before, there are some concerns with this ticket because there's no easy solution for this from a UX point of view without changing the entire behaviour about editing.
          The inline editor should have never been included in the release because it was an initial prototype and we didn't develop it further to improve the way it works, so I think that instead of improving it as part of a bug fix (with all the limitation of the bug fix) the admins should be able to disable that feature, because it was never intended to be in production (it's more like an experimental thing)

          Then, I'm totally up to including a portal.property to disable this feature as described in https://issues.liferay.com/browse/LPS-48701.

          I just sent a pull request to Brian with the portal.property and set it to false by default. You can check the pull here: https://github.com/brianchandotcom/liferay-portal/pull/20000

          I guess that we could backport that portal.property back to 6.2.x and disable by default. That would solve this issue.

          Show
          Sergio Gonzalez added a comment - Hey guys, As Minchau already commented before, there are some concerns with this ticket because there's no easy solution for this from a UX point of view without changing the entire behaviour about editing. The inline editor should have never been included in the release because it was an initial prototype and we didn't develop it further to improve the way it works, so I think that instead of improving it as part of a bug fix (with all the limitation of the bug fix) the admins should be able to disable that feature, because it was never intended to be in production (it's more like an experimental thing) Then, I'm totally up to including a portal.property to disable this feature as described in https://issues.liferay.com/browse/LPS-48701 . I just sent a pull request to Brian with the portal.property and set it to false by default. You can check the pull here: https://github.com/brianchandotcom/liferay-portal/pull/20000 I guess that we could backport that portal.property back to 6.2.x and disable by default. That would solve this issue.
          Hide
          Minhchau Dang added a comment -

          Thanks Sergio.

          Since we're going to resolve this using LPS-48701, I'm going to close this ticket as a duplicate of that one.

          Show
          Minhchau Dang added a comment - Thanks Sergio. Since we're going to resolve this using LPS-48701 , I'm going to close this ticket as a duplicate of that one.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Days since last comment:
                38 weeks, 3 days ago

                Development

                  Structure Helper Panel