Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-47217

Sass cache file change detection does not handle well patching

    Details

      Description

      Patching the sass-cache files is impossible with the current modification time checking method.

      Scenario:

      • html/css/main.css includes portal_1.css which includes add_content.css
      • We make changes in the add_content.css

      When you build the portal the build-css task would regenerate the main.css' sass-cache and would set the modification time of that file to the same as the main.css. Please note that main.css had not been changed and the modification time depends on the last time you have changed branches on git .

      If we patch the portal, the patch would contain the add_content.css changes and the .sass-cache/main.css file. This file would have the modification date of the last git checkout.

      When the user starts the portal, the sass cache file is regenerated every time as it's modification date of the main.css and the .sass-cache/main.css is different.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                brian.chan Brian Chan
                Reporter:
                zsolt.balogh Zsolt Balogh
                Participants of an Issue:
                Recent user:
                Brian Wulbern
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Days since last comment:
                  5 years, 25 weeks ago

                  Packages

                  Version Package
                  6.1.X EE
                  6.2.2 CE GA3
                  6.2.X EE
                  7.0.0 M1