Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-48451

Remove unused logic preventing MonitoringProcessor from being advised by Spring AOP

    Details

      Description

      Originally, we had a ServiceMonitoringAdvice, that attached to all AOP service files - however, because of its name MonitoringService would also be advised (causing unnecessary overhead), unless explicitly ignored.

      In LPS-10842 logic was added to MonitoringService to prevent it from attaching to itself, internalizing its exclusion to its own files and simplifying AOP config to exclude the regex previous required. This logic itself was broken, but was never changed, so the overhead remained.

      In LPS-12197 this overhead was recognized again, so MonitoringService was renamed to MonitoringProcessor. This solved the issue of the extra overhead, as MonitoringProcessor was no longer considered a "Service" bean. However, broken but unreachable logic from LPS-10842 was not removed.

      This ticket removes the broken and unused logic still remaining, and as such should not change behaviour in any capacity.

      Not reproducible by QA.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              brian.chan Brian Chan
              Reporter:
              william.newbury William Newbury
              Participants of an Issue:
              Recent user:
              Esther Sanz
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Days since last comment:
                6 years, 28 weeks, 2 days ago

                  Packages

                  Version Package
                  7.0.0 M1