Remove unused logic preventing MonitoringProcessor from being advised by Spring AOP

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 7.0.0 M3
• Fix Version/s: 7.0.0 M1
• Component/s: Core Infrastructure, Core Infrastructure > Sharding
• Labels: None
• Git Pull Request: https://github.com/brianchandotcom/liferay-portal/pull/19826

Originally, we had a ServiceMonitoringAdvice, that attached to all AOP service files - however, because of its name MonitoringService would also be advised (causing unnecessary overhead), unless explicitly ignored.

In LPS-10842 logic was added to MonitoringService to prevent it from attaching to itself, internalizing its exclusion to its own files and simplifying AOP config to exclude the regex previous required. This logic itself was broken, but was never changed, so the overhead remained.

In LPS-12197 this overhead was recognized again, so MonitoringService was renamed to MonitoringProcessor. This solved the issue of the extra overhead, as MonitoringProcessor was no longer considered a "Service" bean. However, broken but unreachable logic from LPS-10842 was not removed.

This ticket removes the broken and unused logic still remaining, and as such should not change behaviour in any capacity.

Not reproducible by QA.