Details

    • Story Points:
      6
    • Fix Priority:
      3
    • Liferay Contributor's Agreement:
      Accept
    • Similar Issues:
      Show 4 results 

      Description

      On dockbar.css the nested dropdown elements in the Site Administration menu, re styled using hard coded values instead of the more semantic and correct Bootstrap variables, like $dropdownLinkColor and others.

      It also completely forgets to add the :active state to it.

      The issue can be found here: https://github.com/liferay/liferay-portal/blob/000111d8a8d1a12922f667a0679964b7ba17116b/portal-web/docroot/html/themes/_styled/css/dockbar.css#L374

      And here is how bootstrap uses them in v2.3.2: https://github.com/twbs/bootstrap-sass/blob/061ef3280711a36580f278da889658c6a79416e7/vendor/assets/stylesheets/bootstrap/_dropdowns.scss#L92

      Edit:
      This is for 7.0.0
      Copy and paste bs3-sandstone-variables.scss at the bottom of bundles/tomcat-7.0.42/webapps/ROOT/html/themes/_styled/css/_aui_variables.scss
      Drop in _styled-700-theme-7.0.0.1.war into bundles/deploy/
      Restart server
      Sign in as admin
      Click Admin > Control Panel > Sites > Add > Community Site
      Type in a name and click save
      Click Pages > Site Pages
      Select theme _styled-700 at the bottom
      Click save
      In the dockbar, Click My Sites > Your site name
      The dockbar should look like the image.

      There is no fix for 6.2. The work around I use is https://github.com/pat270/lrboilrplate/blob/master/6.2/_styled/css/dockbar.css

        Issue Links

          Activity

          Hide
          Andy Auge (Inactive) added a comment -

          Thank you for your report. What you're describing is more like an improvement to Liferay than a bug in it. With that in mind, I'm going to have your ticket changed into a Feature Request. If you feel this was done in error, please provide some more information here, describing this is more bug-like in its behavior. Thanks!.

          Show
          Andy Auge (Inactive) added a comment - Thank you for your report. What you're describing is more like an improvement to Liferay than a bug in it. With that in mind, I'm going to have your ticket changed into a Feature Request. If you feel this was done in error, please provide some more information here, describing this is more bug-like in its behavior. Thanks!.
          Hide
          Pier Paolo Ramon added a comment -

          I don’t want to look harsh, but this is definitely a bug. Let’s imagine a case where the portal defines a property which controls how often it has to look for changes in LDAP in milliseconds, let’s say that the default is 60000. Now, if an issue reported that somewhere in the portal source (where such an information is needed) there’s no reference to the PortalPropsValues.* but a simple and hardcoded 60000. Would you consider that issue a bug or a feature request?

          Bootstrap defines components as a triad of:

          • conventions in the form classes for names, variants and parts (.navbar, .navbar-inverse, .navbar-inner);
          • conventional and mostly unopinionated minimal styles;
          • a list of variables that permit stable customizations over time.

          In a theme for ≥6.2, as a developer I’m told that I can use both Bootstrap and its themes. Even if full Bootstrap-mode was not achieved by Liferay on purpose, you should care about themes. And themes work for 90% on variables.

          I really want to explain the situation because this is not going to be the last issue of this kind. And I was afraid of precedents!

          Show
          Pier Paolo Ramon added a comment - I don’t want to look harsh, but this is definitely a bug. Let’s imagine a case where the portal defines a property which controls how often it has to look for changes in LDAP in milliseconds, let’s say that the default is 60000 . Now, if an issue reported that somewhere in the portal source (where such an information is needed) there’s no reference to the PortalPropsValues.* but a simple and hardcoded 60000 . Would you consider that issue a bug or a feature request? Bootstrap defines components as a triad of: conventions in the form classes for names, variants and parts ( .navbar , .navbar-inverse , .navbar-inner ); conventional and mostly unopinionated minimal styles; a list of variables that permit stable customizations over time. In a theme for ≥6.2, as a developer I’m told that I can use both Bootstrap and its themes. Even if full Bootstrap-mode was not achieved by Liferay on purpose, you should care about themes. And themes work for 90% on variables. I really want to explain the situation because this is not going to be the last issue of this kind. And I was afraid of precedents!
          Hide
          Pier Paolo Ramon added a comment -

          Made some comment on the PR

          Show
          Pier Paolo Ramon added a comment - Made some comment on the PR
          Show
          Patrick Yeo added a comment - New pull: https://github.com/jonmak08/liferay-portal/pull/1067
          Hide
          Daisy Lin (Inactive) added a comment - - edited

          PASSED Manual Testing following the steps in the description.

          Reproduced on:
          Tomcat 7.0.42 + MySQL 5.5.21 Portal master GIT ID: e529ac5faf184220fcbd6ed29f43218ab1a06f8f.

          Dockbar.css uses hard coded colors.

          Fixed on:
          Tomcat 7.0.42 + MySQL 5.5.21 Portal master GIT ID: 9496dfba49c71f442b49de4df51244756af9b2c0.

          Dockbar.css has dropdownlinkcolor.

          Show
          Daisy Lin (Inactive) added a comment - - edited PASSED Manual Testing following the steps in the description. Reproduced on: Tomcat 7.0.42 + MySQL 5.5.21 Portal master GIT ID: e529ac5faf184220fcbd6ed29f43218ab1a06f8f. Dockbar.css uses hard coded colors. Fixed on: Tomcat 7.0.42 + MySQL 5.5.21 Portal master GIT ID: 9496dfba49c71f442b49de4df51244756af9b2c0. Dockbar.css has dropdownlinkcolor.

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Days since last comment:
                24 weeks, 3 days ago

                Development

                  Structure Helper Panel