Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-50258

Editing DLFileEntry shows wrong action buttons with OVERRIDE_CHECKOUT permissions

Details

    • Bug
    • Status: Closed
    • Resolution: Duplicate
    • 6.2.1 CE GA2
    • 7.0.0 M4
    • Documents & Media
    • None
    • 6

    Description

      If a user has OVERRIDE_CHECKOUT permissions, the edit_file_entry.jsp will render wrong buttons because it thinks, that the file was locked. The relevant code is here:
      https://github.com/liferay/liferay-portal/blob/6.2.x/portal-impl/src/com/liferay/portlet/documentlibrary/service/impl/DLFileEntryServiceImpl.java#L576-L581

      Steps to reproduce:
      1. Create a new file with view, edit and delete permissions for user role
      2. "edit" file and check buttons with a non-admin user
      You will see "Publish", "Checkout" and "Abort" buttons

      3. Give user role override checkout permissions on the file
      4. "edit" file again with non-admin user
      Now the "Checkout" button is gone and you have "Save and Checkin" and "Cancel and Checkout" buttons.

      The code in current master differs, so maybe it's already fixed, not sure about it.

      Attachments

        Issue Links

          Activity

            People

              yvonne.han Yvonne Han
              mod David Kubitza (Inactive)
              Kiyoshi Lee Kiyoshi Lee
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                7 years, 38 weeks, 1 day ago

                Packages

                  Version Package
                  7.0.0 M4