Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-51446

Make the background image URL consistent in CSS

    Details

      Description

      In built-in themes (_styled, classic, control_panel) we use both "../images" and "@theme_image_path@" in background image URL at the same time.

      portal-web/docroot/html/themes/classic/_diffs/css/custom_common.css
      .toggler-header {
      ...
      	.panel-toggle {
      		background: transparent url(../images/arrows/13_right.png) no-repeat 100% -20px;
      	}
      }
      ...
      .opens-new-window-accessible {
      	background: url(@theme_image_path@/common/open_window.png) ...
      }
      

      It would make sense to unify it and use only "@theme_image_path@".

      This inconsistency also causes an issue where images with "../images" URL in their CSS are not loaded in and shown when Liferay runs behind Apache (see the config files attached) on an other context path (e.g. /portal), because context path is missing from the image's URL (see the schreenshots attached). However those images where "@theme_image_path@" are used in their background URL contain the context path and are loaded in without any problem.

        Attachments

        1. httpd.conf
          18 kB
        2. missing_png_1.PNG
          missing_png_1.PNG
          85 kB
        3. missing_png_2.PNG
          missing_png_2.PNG
          95 kB

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Days since last comment:
                5 years, 29 weeks, 1 day ago

                Packages

                Version Package