Missing null check in UpdateUser

• Type: Bug
• Status: Closed
• Resolution: Fixed
• Affects Version/s: 6.2.10 EE GA1, 6.2.X EE, 7.0.0 M4
• Fix Version/s: 6.2.4 CE GA5, 6.2.X EE, 7.0.0 M5
• Component/s: User Management
• Labels:
  • liferay-fixpack-portal-46-6210
• Branch Version/s:
  6.2.x
• Backported to Branch:
  Committed
• Story Points: 14
• Fix Priority: 4
• Git Pull Request: https://github.com/brianchandotcom/liferay-portal/pull/25130
• Bug Type: Regression Bug

While accessing update user method through web service when service context is null, customer is still getting a Null Pointer exception. A null check is missing in the code.

Steps to reproduce:

1) Created web service client or create a portlet.
2) Call below method:
public User updateUser(
long userId, String oldPassword, String newPassword1,
String newPassword2, boolean passwordReset,
String reminderQueryQuestion, String reminderQueryAnswer,
String screenName, String emailAddress, long facebookId,
String openId, String languageId, String timeZoneId,
String greeting, String comments, String firstName,
String middleName, String lastName, long prefixId, long suffixId,
boolean male, int birthdayMonth, int birthdayDay, int birthdayYear,
String smsSn, String aimSn, String facebookSn, String icqSn,
String jabberSn, String msnSn, String mySpaceSn, String skypeSn,
String twitterSn, String ymSn, String jobTitle, long[] groupIds,
long[] organizationIds, long[] roleIds,
List<UserGroupRole> userGroupRoles, long[] userGroupIds,
ServiceContext serviceContext)
throws PortalException
3) Deploy the portlet or execute the webservice , you will get

Expected Result:No Exception
Actual Result:NullPointerException
java.lang.NullPointerException
at com.liferay.portal.service.impl.UserLocalServiceImpl.updateUser(UserLocalServiceImpl.java:5324)