Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-56684

Improve hot deploy mechanism when re-deploying

    Details

      Description

      Situation
      When re-deploying a new version of a hook, the deploy process restores from backup and deploys again the new version of the hook.
      When having different hooks that modify the same language_XX.properties file (each hook overrides different parts), this can lead to some properties to revert to default/old values.

      Steps to reproduce

      1. Consider the following hooks that modify language_en.properties
        • default values
          password=Password
          remember-me=Remember me
        • hook1:
          password=Password? (hook1)
        • hook2:
          remember-me=Remember me, please! (hook2)
        • hook1-20150626
          password=Password, please? (hook1-updated)
      2. Start a 6.1 SP3 bundle
      3. Deploy hook1
        • language values are backed up
        • hook1 is deployed
        • "Password? (hook1)" is displayed (OK)
        • "Remember me" is displayed (OK)
      4. Deploy hook2
        • current language values are backed up
        • hook2 is deployed
        • "Password? (hook1)" is displayed (OK)
        • "Remember me, please! (hook2)" is displayed (OK)
      5. Re-deploy hook1-20150626
        • backed up values are reverted
        • hook1-20150626 is deployed
        • "Password? (hook1)" is displayed (OK)
        • "Remember me" is displayed (Not OK, hook2 value is lost)

      Actual results
      "Password? (hook1)" is displayed (OK)
      "Remember me" is displayed (Not OK, hook2 value is lost)

      Expected results
      "Password? (hook1)" is displayed
      "Remember me, please! (hook2)" is displayed

      Note
      This situation might happen often if there is a hook to override language_xx.properties because portal-compat-hook also overrides this file and it is updated from time to time.

      Request
      Improve hot-deploy process to avoid this conflicting situation.
      Deployment process should only restore modified keys only.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                support-lep@liferay.com SE Support
                Reporter:
                jordi.rodo Jordi Rodó
              • Votes:
                1 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Packages

                  Version Package