Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-58772

Sass partials only need to be imported once per regular scss file

    Details

      Description

      Cannot be tested by QA manually

      We are importing Bourbon, Mixins, and Variables several times inside a regular scss file, it should only be imported once at the beginning.

      Update:

      Remove @import "bourbon" and @import "mixins" from:

      /frontend-theme-classic-web/src/META-INF/resources/classic/_diffs/css/_custom.scss
      /frontend-theme-classic-web/src/META-INF/resources/classic/_diffs/css/_custom_responsive.scss
      /frontend-theme-classic-web/src/META-INF/resources/classic/_diffs/css/portlet/_variables_custom.scss

      /frontend-theme-styled/src/META-INF/resources/_styled/css/_application.scss
      /frontend-theme-styled/src/META-INF/resources/_styled/css/_control_menu.scss
      /frontend-theme-styled/src/META-INF/resources/_styled/css/_extras.scss
      /frontend-theme-styled/src/META-INF/resources/_styled/css/_layout.scss
      /frontend-theme-styled/src/META-INF/resources/_styled/css/_liferay_custom.scss
      /frontend-theme-styled/src/META-INF/resources/_styled/css/_portal.scss
      /frontend-theme-styled/src/META-INF/resources/_styled/css/_portlet.scss
      /frontend-theme-styled/src/META-INF/resources/_styled/css/base/_table_styles.scss
      /frontend-theme-styled/src/META-INF/resources/_styled/css/base/_util.scss
      /frontend-theme-styled/src/META-INF/resources/_styled/css/navigation/_manage_controls.scss
      /frontend-theme-styled/src/META-INF/resources/_styled/css/navigation/_page.scss
      /frontend-theme-styled/src/META-INF/resources/_styled/css/taglib/_drop_here_info.scss
      /frontend-theme-styled/src/META-INF/resources/_styled/css/taglib/_navbar.scss

      Bourbon and Liferay mixins shouldn't work. Add the imports in:

      /frontend-theme-classic-web/src/META-INF/resources/classic/_diffs/css/main.scss
      /frontend-theme-styled/src/META-INF/resources/_styled/css/main.scss
      /frontend-theme-unstyled/src/META-INF/resources/_unstyled/css/main.scss

      Bourbon and Liferay mixins should work. There should be no style changes.

        Attachments

          Activity

            People

            • Assignee:
              felix.zhang Felix Zhang
              Reporter:
              patrick.yeo Patrick Yeo
              Participants of an Issue:
              Recent user:
              Esther Sanz
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Days since last comment:
                4 years, 44 weeks, 2 days ago

                Packages

                Version Package
                7.0.0 Alpha 1