Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-59076

OSGI components shouldn't call the *ServiceUtil class

    Details

    • Story Points:
      1
    • Fix Priority:
      3

      Description

      OSGI components should add references to the Services instead of calling the "ServiceUtil" class.

      See one example here: https://github.com/brianchandotcom/liferay-portal/pull/30658

      To avoid accidnetally creating a circular dependency by converting *ServiceUtil to @Refence inject, we should add an expection rule:

      "When the OSGi Component and the *Service Spring bean are within the same module, don't make this change."

      A typical scenario is, ShoppingCategoryPermission <--> ShoppingCategoryLocalServiceImpl.

        Attachments

          Issue Links

          1.
          Remove calls to *ServiceUtil from componentes in WCM Technical Task Closed Julio Camarero (Inactive)  
          2.
          Remove calls to *ServiceUtil from componentes in DM Technical Task Closed Brian Chan  
          3.
          Remove calls to *ServiceUtil from componentes in BP Technical Task Closed Brian Chan  
          4.
          Remove calls to *ServiceUtil from componentes in Users & Configuration Technical Task Closed Brian Chan  
          5.
          Remove calls to *ServiceUtil from componentes in App Management Technical Task Closed Brian Chan  
          6.
          Remove calls to *ServiceUtil from components in Export/Import and Staging Technical Task Closed Brian Chan  
          7.
          Remove calls to *ServiceUtil from componentes in Collaboration Technical Task Closed Sergio Gonzalez (Inactive)  
          8.
          Remove calls to Registry in WCM Technical Task Closed Julio Camarero (Inactive)  
          9.
          Remove calls to Registry in Export/Import Technical Task Closed Brian Chan  
          10.
          Remove calls to Registry in Business Productivity Technical Task Closed Brian Chan  
          11.
          Remove calls to *ServiceUtil from components in MDR Technical Task Closed Brian Chan  
          12.
          Remove calls to *ServiceUtil from componentes in Mentions Technical Task Closed Brian Chan  
          13.
          Remove calls to *ServiceUtil from componentes in Announcements Technical Task Closed Brian Chan  
          14.
          Remove calls to *ServiceUtil from componentes in Blogs Technical Task Closed Brian Chan  
          15.
          Remove calls to ServiceUtil* from components in Bookmarks Technical Task Closed Brian Chan  
          16.
          Remove calls to ServiceUtil* from components in Comments Technical Task Closed Brian Chan  
          17.
          Remove calls to ServiceUtil* from components in Message Boards Technical Task Closed Brian Chan  
          18.
          Remove calls to *ServiceUtil from wiki engines Technical Task Closed Brian Chan  
          19.
          Remove calls to *ServiceUtil from componentes in Wiki Technical Task Closed Brian Chan  
          20.
          Remove calls to ServiceUtil* from components in Asset Publisher Technical Task Closed Julio Camarero (Inactive)  
          21.
          Remove calls to ServiceUtil* from components in Calendar Technical Task Closed Adam Brandizzi  
          22.
          Remove calls to ServiceUtil* from components in DDL Technical Task Closed Marcellus Tavares  
          23.
          Remove calls to ServiceUtil* from components in DDM Technical Task Closed Marcellus Tavares  
          24.
          Remove calls to ServiceUtil* from components in Invitations Technical Task Closed Brian Chan  
          25.
          Remove calls to ServiceUtil* from components in Layout Admin Technical Task Closed Julio Camarero (Inactive)  
          26.
          Remove calls to ServiceUtil* from components in Microblogs Technical Task Closed Jonathan Lee  
          27.
          Remove calls to ServiceUtil* from components in Plugins Admin Technical Task Closed Julio Camarero (Inactive)  
          28.
          Remove calls to ServiceUtil* from components in Polls Technical Task Closed Brian Chan  
          29.
          Remove calls to ServiceUtil* from components in Portlet Display Template Technical Task Closed Brian Chan  
          30.
          Remove calls to ServiceUtil* from components in Ratings Technical Task Closed Brian Chan  
          31.
          Remove calls to ServiceUtil* from components in Server Admin Technical Task Closed Brian Chan  
          32.
          Remove calls to ServiceUtil* from components in Service Access Policy Technical Task Closed Jorge Ferrer  
          33.
          Remove calls to ServiceUtil* from components in Shopping Technical Task Closed Hugo Huijser  
          34.
          Remove calls to ServiceUtil* from components in Sites Technical Task Closed Julio Camarero (Inactive)  
          35.
          Remove calls to ServiceUtil* from components in Social Technical Task Closed Brian Chan  
          36.
          Remove calls to ServiceUtil* from components in Trash Technical Task Closed Eudaldo Alonso  
          37.
          Remove calls to ServiceUtil* from components in Workflow Technical Task Closed Marcellus Tavares  
          38.
          Remove calls to ServiceUtil* from components in Portal Security Technical Task Closed Brian Chan  
          39.
          Remove calls to ServiceUtil* from components in Portal Store Technical Task Closed Brian Chan  
          40.
          Remove calls to Registry in MDR Technical Task Closed Brian Chan  
          41.
          Remove calls to ServiceUtil* from components in Layout Type Controller Technical Task Closed Brian Chan  
          42.
          Remove calls to ServiceUtil* from components in Portlet TCK Bridge Test Technical Task Closed Brian Chan  
          43.
          Remove calls to Registry in Journal Technical Task Closed Julio Camarero (Inactive)  
          44.
          Remove calls to Registry API in DDM web Technical Task Closed SE Support  
          45.
          Remove last few calls to ServiceUtil* from components in DDM Technical Task Closed Brian Chan  

            Activity

              People

              • Assignee:
                melody.wu Melody Wu
                Reporter:
                julio.camarero Julio Camarero (Inactive)
                Participants of an Issue:
                Recent user:
                Esther Sanz
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Days since last comment:
                  3 years, 37 weeks, 1 day ago

                  Packages

                  Version Package
                  7.0.0 Alpha 2