[LPS-59076] OSGI components shouldn't call the *ServiceUtil class - Liferay Issues

XML

Word

Printable

Details

Type: Bug
Status: Closed
Resolution: Fixed
Affects Version/s: 7.0.0 Alpha 2
Fix Version/s: 7.0.0 Alpha 2
Component/s: Business Productivity, Documents & Media, Staging, ~ [Archived] Collaboration, ~[Archived] WCM
Labels:
None

Story Points:
1
Fix Priority:
3

Description

OSGI components should add references to the Services instead of calling the "ServiceUtil" class.

See one example here: https://github.com/brianchandotcom/liferay-portal/pull/30658

To avoid accidnetally creating a circular dependency by converting *ServiceUtil to @Refence inject, we should add an expection rule:

"When the OSGi Component and the *Service Spring bean are within the same module, don't make this change."

A typical scenario is, ShoppingCategoryPermission <--> ShoppingCategoryLocalServiceImpl.

Attachments

Issue Links

relates

LPS-60774 Regulate service circular dependencies usage

Closed

LPS-62009 Checks in SF to regulate service circular dependencies are too strict

Closed

Options

Sub-Tasks

1.	Remove calls to *ServiceUtil from componentes in WCM	LPS-59077	Closed	Julio Camarero (Inactive)
2.	Remove calls to *ServiceUtil from componentes in DM	LPS-59078	Closed	Brian Chan
3.	Remove calls to *ServiceUtil from componentes in BP	LPS-59079	Closed	Brian Chan
4.	Remove calls to *ServiceUtil from componentes in Users & Configuration	LPS-59080	Closed	Brian Chan
5.	Remove calls to *ServiceUtil from componentes in App Management	LPS-59081	Closed	Brian Chan
6.	Remove calls to *ServiceUtil from components in Export/Import and Staging	LPS-59082	Closed	Brian Chan
7.	Remove calls to *ServiceUtil from componentes in Collaboration	LPS-59122	Closed	Sergio Gonzalez (Inactive)
8.	Remove calls to Registry in WCM	LPS-59421	Closed	Julio Camarero (Inactive)
9.	Remove calls to Registry in Export/Import	LPS-59422	Closed	Brian Chan
10.	Remove calls to Registry in Business Productivity	LPS-59423	Closed	Brian Chan
11.	Remove calls to *ServiceUtil from components in MDR	LPS-59492	Closed	Brian Chan
12.	Remove calls to *ServiceUtil from componentes in Mentions	LPS-59583	Closed	Brian Chan
13.	Remove calls to *ServiceUtil from componentes in Announcements	LPS-59584	Closed	Brian Chan
14.	Remove calls to *ServiceUtil from componentes in Blogs	LPS-59585	Closed	Brian Chan
15.	Remove calls to ServiceUtil* from components in Bookmarks	LPS-59586	Closed	Brian Chan
16.	Remove calls to ServiceUtil* from components in Comments	LPS-59587	Closed	Brian Chan
17.	Remove calls to ServiceUtil* from components in Message Boards	LPS-59588	Closed	Brian Chan
18.	Remove calls to *ServiceUtil from wiki engines	LPS-59590	Closed	Brian Chan
19.	Remove calls to *ServiceUtil from componentes in Wiki	LPS-59592	Closed	Brian Chan
20.	Remove calls to ServiceUtil* from components in Asset Publisher	LPS-59614	Closed	Julio Camarero (Inactive)
21.	Remove calls to ServiceUtil* from components in Calendar	LPS-59615	Closed	Adam Brandizzi
22.	Remove calls to ServiceUtil* from components in DDL	LPS-59616	Closed	Marcellus Tavares
23.	Remove calls to ServiceUtil* from components in DDM	LPS-59617	Closed	Marcellus Tavares
24.	Remove calls to ServiceUtil* from components in Invitations	LPS-59618	Closed	Brian Chan
25.	Remove calls to ServiceUtil* from components in Layout Admin	LPS-59619	Closed	Julio Camarero (Inactive)
26.	Remove calls to ServiceUtil* from components in Microblogs	LPS-59620	Closed	Jonathan Lee
27.	Remove calls to ServiceUtil* from components in Plugins Admin	LPS-59621	Closed	Julio Camarero (Inactive)
28.	Remove calls to ServiceUtil* from components in Polls	LPS-59622	Closed	Brian Chan
29.	Remove calls to ServiceUtil* from components in Portlet Display Template	LPS-59623	Closed	Brian Chan
30.	Remove calls to ServiceUtil* from components in Ratings	LPS-59624	Closed	Brian Chan
31.	Remove calls to ServiceUtil* from components in Server Admin	LPS-59625	Closed	Brian Chan
32.	Remove calls to ServiceUtil* from components in Service Access Policy	LPS-59626	Closed	Jorge Ferrer
33.	Remove calls to ServiceUtil* from components in Shopping	LPS-59627	Closed	Hugo Huijser
34.	Remove calls to ServiceUtil* from components in Sites	LPS-59628	Closed	Julio Camarero (Inactive)
35.	Remove calls to ServiceUtil* from components in Social	LPS-59629	Closed	Brian Chan
36.	Remove calls to ServiceUtil* from components in Trash	LPS-59630	Closed	Eudaldo Alonso
37.	Remove calls to ServiceUtil* from components in Workflow	LPS-59631	Closed	Marcellus Tavares
38.	Remove calls to ServiceUtil* from components in Portal Security	LPS-59632	Closed	Brian Chan
39.	Remove calls to ServiceUtil* from components in Portal Store	LPS-59633	Closed	Brian Chan
40.	Remove calls to Registry in MDR	LPS-59640	Closed	Brian Chan
41.	Remove calls to ServiceUtil* from components in Layout Type Controller	LPS-59855	Closed	Brian Chan
42.	Remove calls to ServiceUtil* from components in Portlet TCK Bridge Test	LPS-59856	Closed	Brian Chan
43.	Remove calls to Registry in Journal	LPS-59939	Closed	Julio Camarero (Inactive)
44.	Remove calls to Registry API in DDM web	LPS-60712	Closed	SE Support
45.	Remove last few calls to ServiceUtil* from components in DDM	LPS-61998	Closed	Brian Chan

Activity

People

Assignee:: Melody Wu

Reporter:: Julio Camarero (Inactive)

Participants of an Issue:: Julio Camarero, Melody Wu

Recent user:: Esther Sanz

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 30/Sep/15 2:37 AM

Updated:: 04/Apr/16 7:40 PM

Resolved:: 15/Oct/15 7:58 PM

Days since last comment:: 5 years, 41 weeks, 3 days ago

Packages

Version	Package
7.0.0 Alpha 2