[LPS-59076] OSGI components shouldn't call the *ServiceUtil class - Liferay Issues

XML

Word

Printable

Details

Type: Bug
Status: Closed
Resolution: Fixed
Affects Version/s: 7.0.0 Alpha 2
Fix Version/s: 7.0.0 Alpha 2
Component/s: Business Productivity, Collaboration, DM, Staging, WCM
Labels:
None

Story Points:
1
Fix Priority:
3

Description

OSGI components should add references to the Services instead of calling the "ServiceUtil" class.

See one example here: https://github.com/brianchandotcom/liferay-portal/pull/30658

To avoid accidnetally creating a circular dependency by converting *ServiceUtil to @Refence inject, we should add an expection rule:

"When the OSGi Component and the *Service Spring bean are within the same module, don't make this change."

A typical scenario is, ShoppingCategoryPermission <--> ShoppingCategoryLocalServiceImpl.

Attachments

Issue Links

relates

LPS-60774 Regulate service circular dependencies usage

Closed

LPS-62009 Checks in SF to regulate service circular dependencies are too strict

Closed

Options

Sub-Tasks

1.	Remove calls to *ServiceUtil from componentes in WCM	Closed	Julio Camarero (Inactive)
2.	Remove calls to *ServiceUtil from componentes in DM	Closed	Brian Chan
3.	Remove calls to *ServiceUtil from componentes in BP	Closed	Brian Chan
4.	Remove calls to *ServiceUtil from componentes in Users & Configuration	Closed	Brian Chan
5.	Remove calls to *ServiceUtil from componentes in App Management	Closed	Brian Chan
6.	Remove calls to *ServiceUtil from components in Export/Import and Staging	Closed	Brian Chan
7.	Remove calls to *ServiceUtil from componentes in Collaboration	Closed	Sergio Gonzalez (Inactive)
8.	Remove calls to Registry in WCM	Closed	Julio Camarero (Inactive)
9.	Remove calls to Registry in Export/Import	Closed	Brian Chan
10.	Remove calls to Registry in Business Productivity	Closed	Brian Chan
11.	Remove calls to *ServiceUtil from components in MDR	Closed	Brian Chan
12.	Remove calls to *ServiceUtil from componentes in Mentions	Closed	Brian Chan
13.	Remove calls to *ServiceUtil from componentes in Announcements	Closed	Brian Chan
14.	Remove calls to *ServiceUtil from componentes in Blogs	Closed	Brian Chan
15.	Remove calls to ServiceUtil* from components in Bookmarks	Closed	Brian Chan
16.	Remove calls to ServiceUtil* from components in Comments	Closed	Brian Chan
17.	Remove calls to ServiceUtil* from components in Message Boards	Closed	Brian Chan
18.	Remove calls to *ServiceUtil from wiki engines	Closed	Brian Chan
19.	Remove calls to *ServiceUtil from componentes in Wiki	Closed	Brian Chan
20.	Remove calls to ServiceUtil* from components in Asset Publisher	Closed	Julio Camarero (Inactive)
21.	Remove calls to ServiceUtil* from components in Calendar	Closed	Adam Brandizzi
22.	Remove calls to ServiceUtil* from components in DDL	Closed	Marcellus Tavares
23.	Remove calls to ServiceUtil* from components in DDM	Closed	Marcellus Tavares
24.	Remove calls to ServiceUtil* from components in Invitations	Closed	Brian Chan
25.	Remove calls to ServiceUtil* from components in Layout Admin	Closed	Julio Camarero (Inactive)
26.	Remove calls to ServiceUtil* from components in Microblogs	Closed	Jonathan Lee
27.	Remove calls to ServiceUtil* from components in Plugins Admin	Closed	Julio Camarero (Inactive)
28.	Remove calls to ServiceUtil* from components in Polls	Closed	Brian Chan
29.	Remove calls to ServiceUtil* from components in Portlet Display Template	Closed	Brian Chan
30.	Remove calls to ServiceUtil* from components in Ratings	Closed	Brian Chan
31.	Remove calls to ServiceUtil* from components in Server Admin	Closed	Brian Chan
32.	Remove calls to ServiceUtil* from components in Service Access Policy	Closed	Jorge Ferrer
33.	Remove calls to ServiceUtil* from components in Shopping	Closed	Hugo Huijser
34.	Remove calls to ServiceUtil* from components in Sites	Closed	Julio Camarero (Inactive)
35.	Remove calls to ServiceUtil* from components in Social	Closed	Brian Chan
36.	Remove calls to ServiceUtil* from components in Trash	Closed	Eudaldo Alonso
37.	Remove calls to ServiceUtil* from components in Workflow	Closed	Marcellus Tavares
38.	Remove calls to ServiceUtil* from components in Portal Security	Closed	Brian Chan
39.	Remove calls to ServiceUtil* from components in Portal Store	Closed	Brian Chan
40.	Remove calls to Registry in MDR	Closed	Brian Chan
41.	Remove calls to ServiceUtil* from components in Layout Type Controller	Closed	Brian Chan
42.	Remove calls to ServiceUtil* from components in Portlet TCK Bridge Test	Closed	Brian Chan
43.	Remove calls to Registry in Journal	Closed	Julio Camarero (Inactive)
44.	Remove calls to Registry API in DDM web	Closed	SE Support
45.	Remove last few calls to ServiceUtil* from components in DDM	Closed	Brian Chan

Activity

People

Assignee:

Melody Wu

Reporter:

Julio Camarero (Inactive)

Participants of an Issue:

Julio Camarero, Melody Wu

Recent user:

Esther Sanz

Votes:

0 Vote for this issue

Watchers:

1 Start watching this issue

Dates

Created:

30/Sep/15 2:37 AM

Updated:

04/Apr/16 7:40 PM

Resolved:

15/Oct/15 7:58 PM

Days since last comment:

3 years, 37 weeks, 1 day ago

Packages

Version	Package
7.0.0 Alpha 2