Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-59076

OSGI components shouldn't call the *ServiceUtil class

    Details

    • Story Points:
      1
    • Fix Priority:
      3

      Description

      OSGI components should add references to the Services instead of calling the "ServiceUtil" class.

      See one example here: https://github.com/brianchandotcom/liferay-portal/pull/30658

      To avoid accidnetally creating a circular dependency by converting *ServiceUtil to @Refence inject, we should add an expection rule:

      "When the OSGi Component and the *Service Spring bean are within the same module, don't make this change."

      A typical scenario is, ShoppingCategoryPermission <--> ShoppingCategoryLocalServiceImpl.

        Attachments

          Issue Links

          1.
          Remove calls to *ServiceUtil from componentes in WCM LPS-59077 Technical Task Closed Julio Camarero (Inactive)  
          2.
          Remove calls to *ServiceUtil from componentes in DM LPS-59078 Technical Task Closed Brian Chan  
          3.
          Remove calls to *ServiceUtil from componentes in BP LPS-59079 Technical Task Closed Brian Chan  
          4.
          Remove calls to *ServiceUtil from componentes in Users & Configuration LPS-59080 Technical Task Closed Brian Chan  
          5.
          Remove calls to *ServiceUtil from componentes in App Management LPS-59081 Technical Task Closed Brian Chan  
          6.
          Remove calls to *ServiceUtil from components in Export/Import and Staging LPS-59082 Technical Task Closed Brian Chan  
          7.
          Remove calls to *ServiceUtil from componentes in Collaboration LPS-59122 Technical Task Closed Sergio Gonzalez (Inactive)  
          8.
          Remove calls to Registry in WCM LPS-59421 Technical Task Closed Julio Camarero (Inactive)  
          9.
          Remove calls to Registry in Export/Import LPS-59422 Technical Task Closed Brian Chan  
          10.
          Remove calls to Registry in Business Productivity LPS-59423 Technical Task Closed Brian Chan  
          11.
          Remove calls to *ServiceUtil from components in MDR LPS-59492 Technical Task Closed Brian Chan  
          12.
          Remove calls to *ServiceUtil from componentes in Mentions LPS-59583 Technical Task Closed Brian Chan  
          13.
          Remove calls to *ServiceUtil from componentes in Announcements LPS-59584 Technical Task Closed Brian Chan  
          14.
          Remove calls to *ServiceUtil from componentes in Blogs LPS-59585 Technical Task Closed Brian Chan  
          15.
          Remove calls to ServiceUtil* from components in Bookmarks LPS-59586 Technical Task Closed Brian Chan  
          16.
          Remove calls to ServiceUtil* from components in Comments LPS-59587 Technical Task Closed Brian Chan  
          17.
          Remove calls to ServiceUtil* from components in Message Boards LPS-59588 Technical Task Closed Brian Chan  
          18.
          Remove calls to *ServiceUtil from wiki engines LPS-59590 Technical Task Closed Brian Chan  
          19.
          Remove calls to *ServiceUtil from componentes in Wiki LPS-59592 Technical Task Closed Brian Chan  
          20.
          Remove calls to ServiceUtil* from components in Asset Publisher LPS-59614 Technical Task Closed Julio Camarero (Inactive)  
          21.
          Remove calls to ServiceUtil* from components in Calendar LPS-59615 Technical Task Closed Adam Brandizzi  
          22.
          Remove calls to ServiceUtil* from components in DDL LPS-59616 Technical Task Closed Marcellus Tavares  
          23.
          Remove calls to ServiceUtil* from components in DDM LPS-59617 Technical Task Closed Marcellus Tavares  
          24.
          Remove calls to ServiceUtil* from components in Invitations LPS-59618 Technical Task Closed Brian Chan  
          25.
          Remove calls to ServiceUtil* from components in Layout Admin LPS-59619 Technical Task Closed Julio Camarero (Inactive)  
          26.
          Remove calls to ServiceUtil* from components in Microblogs LPS-59620 Technical Task Closed Jonathan Lee  
          27.
          Remove calls to ServiceUtil* from components in Plugins Admin LPS-59621 Technical Task Closed Julio Camarero (Inactive)  
          28.
          Remove calls to ServiceUtil* from components in Polls LPS-59622 Technical Task Closed Brian Chan  
          29.
          Remove calls to ServiceUtil* from components in Portlet Display Template LPS-59623 Technical Task Closed Brian Chan  
          30.
          Remove calls to ServiceUtil* from components in Ratings LPS-59624 Technical Task Closed Brian Chan  
          31.
          Remove calls to ServiceUtil* from components in Server Admin LPS-59625 Technical Task Closed Brian Chan  
          32.
          Remove calls to ServiceUtil* from components in Service Access Policy LPS-59626 Technical Task Closed Jorge Ferrer  
          33.
          Remove calls to ServiceUtil* from components in Shopping LPS-59627 Technical Task Closed Hugo Huijser  
          34.
          Remove calls to ServiceUtil* from components in Sites LPS-59628 Technical Task Closed Julio Camarero (Inactive)  
          35.
          Remove calls to ServiceUtil* from components in Social LPS-59629 Technical Task Closed Brian Chan  
          36.
          Remove calls to ServiceUtil* from components in Trash LPS-59630 Technical Task Closed Eudaldo Alonso  
          37.
          Remove calls to ServiceUtil* from components in Workflow LPS-59631 Technical Task Closed Marcellus Tavares  
          38.
          Remove calls to ServiceUtil* from components in Portal Security LPS-59632 Technical Task Closed Brian Chan  
          39.
          Remove calls to ServiceUtil* from components in Portal Store LPS-59633 Technical Task Closed Brian Chan  
          40.
          Remove calls to Registry in MDR LPS-59640 Technical Task Closed Brian Chan  
          41.
          Remove calls to ServiceUtil* from components in Layout Type Controller LPS-59855 Technical Task Closed Brian Chan  
          42.
          Remove calls to ServiceUtil* from components in Portlet TCK Bridge Test LPS-59856 Technical Task Closed Brian Chan  
          43.
          Remove calls to Registry in Journal LPS-59939 Technical Task Closed Julio Camarero (Inactive)  
          44.
          Remove calls to Registry API in DDM web LPS-60712 Technical Task Closed SE Support  
          45.
          Remove last few calls to ServiceUtil* from components in DDM LPS-61998 Technical Task Closed Brian Chan  

            Activity

              People

              Assignee:
              melody.wu Melody Wu
              Reporter:
              julio.camarero Julio Camarero (Inactive)
              Participants of an Issue:
              Recent user:
              Esther Sanz
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Days since last comment:
                4 years, 47 weeks, 4 days ago

                  Packages

                  Version Package
                  7.0.0 Alpha 2