Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-64380

NullPointerException from UpgradeSocial breaks Upgrade

    Details

      Description

      in the 6.2 UpgradeSocial.createExtraData(), we return:

      return extraDataJSONObject.toString();
      

      However, this can and does create NullPointerExceptions.

      the interesting thing is that the caller of this method is:

      String newExtraData = createExtraData(
      						extraDataFactory, groupId, companyId, userId,
      						classNameId, classPK, type, extraData);
      
      					if (newExtraData != null) {
      						extraDataMap.put(activityId, newExtraData);
      					}
      

      Which is prepared for a null value returned. We cannot do a .toString() on a null and get a null returned. Validate and return if null to fix.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                marcy.dong Marcy Dong (Inactive)
                Reporter:
                brett.swaim Brett Swaim
                Participants of an Issue:
                Recent user:
                Esther Sanz
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Days since last comment:
                  3 years, 38 weeks, 1 day ago

                  Packages

                  Version Package
                  7.0.0 CE RC1