Upgrades - New upgrade tool does not interpret backslashes in Windows property files correctly

• Type: Bug
• Status: Closed
• Resolution: No Longer Reproducible
• Affects Version/s: 7.0.1 CE GA2
• Fix Version/s: Master
• Component/s: Core Infrastructure, Core Infrastructure > DB Upgrade Client, Core Infrastructure > Upgrade Framework
• Labels:
  • DBUPGRADECLIENT
  • KNOWNISSUES_DE70
  • LR7UPGRADE
• Fix Priority: 4
• OS:
  Windows 8
• Sprint: Ferroskutterudite, Gahnospinel

Steps to reproduce:

1. In Windows, unzip a new bundle
2. Run the command

    cd {portal.source}/modules/util/portal-tools-db-upgrade-client/../../../gradlew deploy 

   to generate the upgrade tool in

    {bundle.home}/tools 

3. In

    {bundle.home}/tools/portal-tools-db-upgrade-client 

   set

    liferay.home= 

   and add anything additional to portal-upgrade-ext.properties

4. Run

    java -jar com.liferay.portal.tools.db.upgrade.client.jar 

   and follow the prompts in cmd

Expected result:
Directories are set and read properly in app-server.properties during the upgrade, and the bundle upgrades successfully.

Actual result:
Upgrade fails. The following console error appears:

Error: Could not find or load main class com.liferay.portal.tools.DBUpgrader
Exiting Gogo shell.

The paths generated in app-server.properties

 
dir=D:\liferay-dxp-digital-enterprise-7.0-b3\tools\tomcat-8.0.32 
portal.dir=webapps\ROOT
global.dir.lib=lib

are created, but the upgrade tool does not interpret

 \ 

correctly.

Workaround:
If I edit app-server.properties to have the lines

dir=D:/liferay-dxp-digital-enterprise-7.0-b3/tomcat-8.0.32
portal.dir=webapps/ROOT
global.dir.lib=lib

and portal-upgrade-ext.properties to have

liferay.home=D:/liferay-dxp-digital-enterprise-7.0-b3

and rerun the upgrade, the upgrade will execute successfully.

Reproduced on:
Tomcat 8.0.32 + MySQL 5.6.
Portal master GIT ID: a9d2bd9d7cc1919d87af73e71b7938d530eb3fae
Windows 8.1.

Update 4/27

The behavior of the upgrade tool has changed. Now, after going through steps 1-4 I am greeted with the console error

Error: Could not find or load main class com.liferay.portal.tools.DBUpgrader
Picked up _JAVA_OPTIONS: -Xms2048m -Xmx4000m -XX:MaxPermSize=2048m
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=2048m; support was removed in 8.0
Exiting from Gogo shell.

After running the jar again, the upgrade executes without issues.

Reproduced on:
Tomcat 8.0.32 + MySQL 5.6, Oracle 11g
Portal ee-7.0.x GIT ID: dc32534b425efaeef0da2192236108533605c5e7
Windows 8.1.