Uploaded image for project: 'PUBLIC - Liferay Portal Community Edition'
  1. PUBLIC - Liferay Portal Community Edition
  2. LPS-65432

Wrong method names on ControlMenuEntry API

    Details

    • Type: Bug
    • Status: Closed
    • Resolution: Fixed
    • Affects Version/s: 7.0.1 CE GA2
    • Fix Version/s: 7.0.1 CE GA2
    • Component/s: Product Menu
    • Labels:
      None

      Description

      Actually we have one method in ControlMenuEntry API to set the icon of an control menu entry:

      public String getIconCssClass(HttpServletRequest request);
      

      so, we need to add two new methods to allow users to have lexicon icons and css icons, because right now, we are using the getIconCssClass method to set the lexicon icons, and it is no correct.

      public String getIcon(HttpServletRequest request);
      
      public String getMarkupView(HttpServletRequest request);
      

      If we want to use a lexicon icon, we should override the method like this:

      public String getIconCssClass(HttpServletRequest request) {
        return "";
      }
      
      public String getIcon(HttpServletRequest request) {
         return "lexicon-icon"; // Where "lexicon-icon" is an icon in [http://liferay.github.io/lexicon/content/icons-lexicon/]
      }
      
      public String getMarkupView(HttpServletRequest request) {
         return "lexicon";
      }
      

      If we want to use a css icon, we should override the method like this:

      public String getIconCssClass(HttpServletRequest request) {
        return "icon-css"; // Where "icon-css" is an icon in [http://liferay.github.io/lexicon/content/icons-font-awesome/]
      }
      
      public String getIcon(HttpServletRequest request) {
         return "";
      }
      
      public String getMarkupView(HttpServletRequest request) {
         return "";
      }
      

      It cannot be tested by QA.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              ian.song Ian Song (Inactive)
              Reporter:
              eudaldo.alonso Eudaldo Alonso
              Participants of an Issue:
              Recent user:
              Marta Elicegui
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Days since last comment:
                5 years, 8 weeks, 2 days ago

                  Packages

                  Version Package
                  7.0.1 CE GA2